[vala/0.40] Revert "vala: Set default_construction_method in semantic-analyzer check if required"

[Rico Tzschichholz <ricotz src gnome org>]

commit 7ef734bae6912e5e8af15e3847ec87a27a07b2f5
Author: Rico Tzschichholz <ricotz ubuntu com>
Date:   Thu Apr 23 07:44:21 2020 +0200

    Revert "vala: Set default_construction_method in semantic-analyzer check if required"
    
    This reverts commit d176f179581fac880f5598bb53b3475392af2c4b.
    
    Fixes https://gitlab.gnome.org/GNOME/vala/issues/982

 vala/valaclass.vala  | 9 ---------
 vala/valaparser.vala | 9 +++++++++
 2 files changed, 9 insertions(+), 9 deletions(-)
---
diff --git a/vala/valaclass.vala b/vala/valaclass.vala
index bad6ea51a..532acc19d 100644
--- a/vala/valaclass.vala
+++ b/vala/valaclass.vala
@@ -504,15 +504,6 @@ public class Vala.Class : ObjectTypeSymbol {
 
                checked = true;
 
-               // ensure there is always a default construction method
-               if (default_construction_method == null
-                   && source_reference.file.file_type == SourceFileType.SOURCE) {
-                       var m = new CreationMethod (name, null, source_reference);
-                       m.access = (is_abstract ? SymbolAccessibility.PROTECTED : SymbolAccessibility.PUBLIC);
-                       m.body = new Block (source_reference);
-                       add_method (m);
-               }
-
                var old_source_file = context.analyzer.current_source_file;
                var old_symbol = context.analyzer.current_symbol;
 
diff --git a/vala/valaparser.vala b/vala/valaparser.vala
index 91594e3bd..1e34d8b40 100644
--- a/vala/valaparser.vala
+++ b/vala/valaparser.vala
@@ -2609,6 +2609,15 @@ public class Vala.Parser : CodeVisitor {
 
                parse_declarations (cl);
 
+               // ensure there is always a default construction method
+               if (scanner.source_file.file_type == SourceFileType.SOURCE
+                   && cl.default_construction_method == null) {
+                       var m = new CreationMethod (cl.name, null, cl.source_reference);
+                       m.access = (cl.is_abstract ? SymbolAccessibility.PROTECTED : 
SymbolAccessibility.PUBLIC);
+                       m.body = new Block (cl.source_reference);
+                       cl.add_method (m);
+               }
+
                Symbol result = cl;
                while (sym != null) {
                        sym = sym.inner;