[tracker/sam/debug: 3/5] Add SQL_INDEXES debug flag and hide index creation logs by defualt

[Sam Thursfield <sthursfield src gnome org>]

commit 7a28a0f0c3f6fcfcd403cd50ac762feeec88b2e4
Author: Sam Thursfield <sam afuera me uk>
Date:   Mon Apr 20 00:53:27 2020 +0200

    Add SQL_INDEXES debug flag and hide index creation logs by defualt

 src/libtracker-common/tracker-debug.c      |  1 +
 src/libtracker-common/tracker-debug.h      |  3 +-
 src/libtracker-data/tracker-data-manager.c | 76 +++++++++++++++---------------
 3 files changed, 40 insertions(+), 40 deletions(-)
---
diff --git a/src/libtracker-common/tracker-debug.c b/src/libtracker-common/tracker-debug.c
index 75b8d2840..dc3750a41 100644
--- a/src/libtracker-common/tracker-debug.c
+++ b/src/libtracker-common/tracker-debug.c
@@ -23,6 +23,7 @@
 
 #ifdef G_ENABLE_DEBUG
 static const GDebugKey tracker_debug_keys[] = {
+  { "sql-indexes", TRACKER_DEBUG_SQL_INDEXES },
   { "sql-statements", TRACKER_DEBUG_SQL_STATEMENTS },
 };
 #endif /* G_ENABLE_DEBUG */
diff --git a/src/libtracker-common/tracker-debug.h b/src/libtracker-common/tracker-debug.h
index aaca4fc07..b64c964b9 100644
--- a/src/libtracker-common/tracker-debug.h
+++ b/src/libtracker-common/tracker-debug.h
@@ -29,7 +29,8 @@
 G_BEGIN_DECLS
 
 typedef enum {
-  TRACKER_DEBUG_SQL_STATEMENTS  = 1 <<  1,
+  TRACKER_DEBUG_SQL_INDEXES     = 1 <<  1,
+  TRACKER_DEBUG_SQL_STATEMENTS  = 1 <<  2,
 } TrackerDebugFlag;
 
 #ifdef G_ENABLE_DEBUG
diff --git a/src/libtracker-data/tracker-data-manager.c b/src/libtracker-data/tracker-data-manager.c
index 60621d397..44a2de23f 100644
--- a/src/libtracker-data/tracker-data-manager.c
+++ b/src/libtracker-data/tracker-data-manager.c
@@ -32,6 +32,7 @@
 
 #include <libtracker-fts/tracker-fts.h>
 
+#include <libtracker-common/tracker-debug.h>
 #include <libtracker-common/tracker-locale.h>
 
 #include "tracker-class.h"
@@ -232,9 +233,10 @@ set_secondary_index_for_single_value_property (TrackerDBInterface  *iface,
 {
        GError *internal_error = NULL;
 
-       g_debug ("Dropping secondary index (single-value property):  "
-                "DROP INDEX IF EXISTS \"%s_%s\"",
-                service_name, field_name);
+       TRACKER_NOTE (SQL_INDEXES,
+                     g_message ("Dropping secondary index (single-value property):  "
+                                "DROP INDEX IF EXISTS \"%s_%s\"",
+                                service_name, field_name));
 
        tracker_db_interface_execute_query (iface, &internal_error,
                                            "DROP INDEX IF EXISTS \"%s\".\"%s_%s\"",
@@ -248,9 +250,10 @@ set_secondary_index_for_single_value_property (TrackerDBInterface  *iface,
        }
 
        if (enabled) {
-               g_debug ("Creating secondary index (single-value property): "
-                        "CREATE INDEX \"%s_%s\" ON \"%s\" (\"%s\", \"%s\")",
-                        service_name, field_name, service_name, field_name, second_field_name);
+               TRACKER_NOTE (SQL_INDEXES,
+                             g_message ("Creating secondary index (single-value property): "
+                                        "CREATE INDEX \"%s_%s\" ON \"%s\" (\"%s\", \"%s\")",
+                                        service_name, field_name, service_name, field_name, 
second_field_name));
 
                tracker_db_interface_execute_query (iface, &internal_error,
                                                    "CREATE INDEX \"%s\".\"%s_%s\" ON \"%s\" (\"%s\", 
\"%s\")",
@@ -278,9 +281,10 @@ set_index_for_single_value_property (TrackerDBInterface  *iface,
 {
        GError *internal_error = NULL;
 
-       g_debug ("Dropping index (single-value property): "
-                "DROP INDEX IF EXISTS \"%s_%s\"",
-                service_name, field_name);
+       TRACKER_NOTE (SQL_INDEXES,
+                     g_message ("Dropping index (single-value property): "
+                                "DROP INDEX IF EXISTS \"%s_%s\"",
+                                service_name, field_name));
 
        tracker_db_interface_execute_query (iface, &internal_error,
                                            "DROP INDEX IF EXISTS \"%s\".\"%s_%s\"",
@@ -301,9 +305,10 @@ set_index_for_single_value_property (TrackerDBInterface  *iface,
                else
                        expr = g_strdup_printf ("\"%s\"", field_name);
 
-               g_debug ("Creating index (single-value property): "
-                        "CREATE INDEX \"%s_%s\" ON \"%s\" (%s)",
-                        service_name, field_name, service_name, expr);
+               TRACKER_NOTE (SQL_INDEXES,
+                             g_message ("Creating index (single-value property): "
+                                        "CREATE INDEX \"%s_%s\" ON \"%s\" (%s)",
+                                        service_name, field_name, service_name, expr));
 
                tracker_db_interface_execute_query (iface, &internal_error,
                                                    "CREATE INDEX \"%s\".\"%s_%s\" ON \"%s\" (%s)",
@@ -333,9 +338,10 @@ set_index_for_multi_value_property (TrackerDBInterface  *iface,
        GError *internal_error = NULL;
        gchar *expr;
 
-       g_debug ("Dropping index (multi-value property): "
-                "DROP INDEX IF EXISTS \"%s_%s_ID_ID\"",
-                service_name, field_name);
+       TRACKER_NOTE (SQL_INDEXES,
+                     g_message ("Dropping index (multi-value property): "
+                                "DROP INDEX IF EXISTS \"%s_%s_ID_ID\"",
+                                service_name, field_name));
 
        tracker_db_interface_execute_query (iface, &internal_error,
                                            "DROP INDEX IF EXISTS \"%s\".\"%s_%s_ID_ID\"",
@@ -351,10 +357,10 @@ set_index_for_multi_value_property (TrackerDBInterface  *iface,
        /* Useful to have this here for the cases where we want to fully
         * re-create the indexes even without an ontology change (when locale
         * of the user changes) */
-       g_debug ("Dropping index (multi-value property): "
-                "DROP INDEX IF EXISTS \"%s_%s_ID\"",
-                service_name,
-                field_name);
+       TRACKER_NOTE (SQL_INDEXES,
+                     g_message ("Dropping index (multi-value property): "
+                                "DROP INDEX IF EXISTS \"%s_%s_ID\"",
+                                service_name, field_name));
        tracker_db_interface_execute_query (iface, &internal_error,
                                            "DROP INDEX IF EXISTS \"%s\".\"%s_%s_ID\"",
                                            database,
@@ -376,12 +382,10 @@ set_index_for_multi_value_property (TrackerDBInterface  *iface,
                expr = g_strdup_printf ("\"%s\"", field_name);
 
        if (enabled) {
-               g_debug ("Creating index (multi-value property): "
-                        "CREATE INDEX \"%s_%s_ID\" ON \"%s_%s\" (ID)",
-                        service_name,
-                        field_name,
-                        service_name,
-                        field_name);
+               TRACKER_NOTE (SQL_INDEXES,
+                             g_message ("Creating index (multi-value property): "
+                                        "CREATE INDEX \"%s_%s_ID\" ON \"%s_%s\" (ID)",
+                                        service_name, field_name, service_name, field_name));
 
                tracker_db_interface_execute_query (iface, &internal_error,
                                                    "CREATE INDEX \"%s\".\"%s_%s_ID\" ON \"%s_%s\" (ID)",
@@ -396,13 +400,10 @@ set_index_for_multi_value_property (TrackerDBInterface  *iface,
                        return;
                }
 
-               g_debug ("Creating index (multi-value property): "
-                        "CREATE UNIQUE INDEX \"%s_%s_ID_ID\" ON \"%s_%s\" (%s, ID)",
-                        service_name,
-                        field_name,
-                        service_name,
-                        field_name,
-                        expr);
+               TRACKER_NOTE (SQL_INDEXES,
+                             g_message ("Creating index (multi-value property): "
+                                       "CREATE UNIQUE INDEX \"%s_%s_ID_ID\" ON \"%s_%s\" (%s, ID)",
+                                       service_name, field_name, service_name, field_name, expr));
 
                tracker_db_interface_execute_query (iface, &internal_error,
                                                    "CREATE UNIQUE INDEX \"%s\".\"%s_%s_ID_ID\" ON \"%s_%s\" 
(%s, ID)",
@@ -418,13 +419,10 @@ set_index_for_multi_value_property (TrackerDBInterface  *iface,
                        return;
                }
        } else {
-               g_debug ("Creating index (multi-value property): "
-                        "CREATE UNIQUE INDEX \"%s_%s_ID_ID\" ON \"%s_%s\" (ID, %s)",
-                        service_name,
-                        field_name,
-                        service_name,
-                        field_name,
-                        expr);
+               TRACKER_NOTE (SQL_INDEXES,
+                             g_message ("Creating index (multi-value property): "
+                                        "CREATE UNIQUE INDEX \"%s_%s_ID_ID\" ON \"%s_%s\" (ID, %s)",
+                                        service_name, field_name, service_name, field_name, expr));
 
                tracker_db_interface_execute_query (iface, &internal_error,
                                                    "CREATE UNIQUE INDEX \"%s\".\"%s_%s_ID_ID\" ON \"%s_%s\" 
(ID, %s)",