[gtk/BUG_filechooserbutton_remote_GTK3] FileChooserButton: query 'display name' also for unbookmarked files
- From: Nelson Benítez León <nbenitez src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk/BUG_filechooserbutton_remote_GTK3] FileChooserButton: query 'display name' also for unbookmarked files
- Date: Sun, 19 Apr 2020 18:32:34 +0000 (UTC)
commit b01f371ce61f8077bb70a2b6024f4163fafffc5c
Author: Nelson Benítez León <nbenitezl gmail com>
Date: Sun Apr 19 14:16:02 2020 -0400
FileChooserButton: query 'display name' also for unbookmarked files
Do also the async file info query for remote files when they
are not bookmarked, because otherwise "None" will be shown as
file name (and fallback text generic icon will be used).
The remote file was already browsed by the file chooser
instance when selecting it, so querying the display name
again should be using gio cache and not be slow.
Even if it's were slow it's better than showing 'None'
which makes it seem as if nothing was selected.
Fixes #1966
gtk/gtkfilechooserbutton.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/gtk/gtkfilechooserbutton.c b/gtk/gtkfilechooserbutton.c
index fa9b945b7f..8711385d30 100644
--- a/gtk/gtkfilechooserbutton.c
+++ b/gtk/gtkfilechooserbutton.c
@@ -2550,7 +2550,8 @@ update_label_and_image (GtkFileChooserButton *button)
}
}
- if (g_file_is_native (file))
+ if (g_file_is_native (file) ||
+ !_gtk_bookmarks_manager_has_bookmark (button->priv->bookmarks_manager, file))
{
priv->update_button_cancellable =
_gtk_file_system_get_info (priv->fs, file,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]