[gnumeric] Workbook view: improve error message.



commit 523198973178ac9ed220d8488ee78b61c37b6a0c
Author: Morten Welinder <terra gnome org>
Date:   Sun Apr 12 15:53:51 2020 -0400

    Workbook view: improve error message.

 ChangeLog           |  5 +++++
 NEWS                |  1 +
 src/workbook-view.c | 11 +++++++++--
 3 files changed, 15 insertions(+), 2 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 28e04185e..f4f4680a8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2020-04-12  Morten Welinder  <terra gnome org>
+
+       * src/workbook-view.c (workbook_view_new_from_input): Spell out
+       which file we complain over.  See #472.
+
 2020-03-03  Morten Welinder  <terra gnome org>
 
        * src/ssconvert.c (apply_updates): Move NULL check into here so
diff --git a/NEWS b/NEWS
index 248407e8a..05b5aaf2c 100644
--- a/NEWS
+++ b/NEWS
@@ -5,6 +5,7 @@ Morten:
        * Add "--set CELL=CONTENTS" option to ssconvert.
        * Improve tests.
        * Improve speed on exit with lots of conditional formatting.
+       * Improve error message [#472]
 
 --------------------------------------------------------------------------
 Gnumeric 1.12.46
diff --git a/src/workbook-view.c b/src/workbook-view.c
index 7cf469801..ead18f505 100644
--- a/src/workbook-view.c
+++ b/src/workbook-view.c
@@ -1401,10 +1401,17 @@ workbook_view_new_from_input (GsfInput *input,
                                        (new_wb, uri);
                }
        } else {
-               if (io_context)
+               if (io_context) {
+                       char *bn = go_basename_from_uri (uri);
+                       char *errtxt = g_strdup_printf
+                               (_("Unsupported file format for file \"%s\""),
+                                bn);
                        go_cmd_context_error_import
                                (GO_CMD_CONTEXT (io_context),
-                                _("Unsupported file format."));
+                                errtxt);
+                       g_free (errtxt);
+                       g_free (bn);
+               }
        }
 
        return new_wbv;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]