[gtk/wip/baedert/for-master] label: Remove GtkLabel::selection-bound



commit 593fd05a4fe7eb32eabd0abe10da852ecb199743
Author: Timm Bäder <mail baedert org>
Date:   Sun Apr 12 10:24:24 2020 +0200

    label: Remove GtkLabel::selection-bound
    
    Unused and the getter never had public API anyway. Also there is
    gtk_label_get_selection_bounds if people really want this.

 gtk/gtklabel.c        | 28 ----------------------------
 gtk/gtklabelprivate.h |  1 -
 2 files changed, 29 deletions(-)
---
diff --git a/gtk/gtklabel.c b/gtk/gtklabel.c
index deefff139e..9b8d94ce93 100644
--- a/gtk/gtklabel.c
+++ b/gtk/gtklabel.c
@@ -398,7 +398,6 @@ enum {
   PROP_MNEMONIC_KEYVAL,
   PROP_MNEMONIC_WIDGET,
   PROP_CURSOR_POSITION,
-  PROP_SELECTION_BOUND,
   PROP_ELLIPSIZE,
   PROP_WIDTH_CHARS,
   PROP_SINGLE_LINE_MODE,
@@ -883,15 +882,6 @@ gtk_label_class_init (GtkLabelClass *class)
                         0, G_MAXINT,
                         0,
                         GTK_PARAM_READABLE);
-
-  label_props[PROP_SELECTION_BOUND] =
-      g_param_spec_int ("selection-bound",
-                        P_("Selection Bound"),
-                        P_("The position of the opposite end of the selection from the cursor in chars"),
-                        0, G_MAXINT,
-                        0,
-                        GTK_PARAM_READABLE);
-
   /**
    * GtkLabel:ellipsize:
    *
@@ -1272,9 +1262,6 @@ gtk_label_get_property (GObject     *object,
     case PROP_CURSOR_POSITION:
       g_value_set_int (value, _gtk_label_get_cursor_position (label));
       break;
-    case PROP_SELECTION_BOUND:
-      g_value_set_int (value, _gtk_label_get_selection_bound (label));
-      break;
     case PROP_ELLIPSIZE:
       g_value_set_enum (value, priv->ellipsize);
       break;
@@ -4781,7 +4768,6 @@ gtk_label_set_selectable (GtkLabel *label,
       g_object_freeze_notify (G_OBJECT (label));
       g_object_notify_by_pspec (G_OBJECT (label), label_props[PROP_SELECTABLE]);
       g_object_notify_by_pspec (G_OBJECT (label), label_props[PROP_CURSOR_POSITION]);
-      g_object_notify_by_pspec (G_OBJECT (label), label_props[PROP_SELECTION_BOUND]);
       g_object_thaw_notify (G_OBJECT (label));
       gtk_widget_queue_draw (GTK_WIDGET (label));
     }
@@ -4878,8 +4864,6 @@ gtk_label_select_region_index (GtkLabel *label,
 
       g_object_freeze_notify (G_OBJECT (label));
 
-      if (priv->select_info->selection_anchor != anchor_index)
-        g_object_notify_by_pspec (G_OBJECT (label), label_props[PROP_SELECTION_BOUND]);
       if (priv->select_info->selection_end != end_index)
         g_object_notify_by_pspec (G_OBJECT (label), label_props[PROP_CURSOR_POSITION]);
 
@@ -5992,18 +5976,6 @@ _gtk_label_get_cursor_position (GtkLabel *label)
   return 0;
 }
 
-gint
-_gtk_label_get_selection_bound (GtkLabel *label)
-{
-  GtkLabelPrivate *priv = gtk_label_get_instance_private (label);
-
-  if (priv->select_info && priv->select_info->selectable)
-    return g_utf8_pointer_to_offset (priv->text,
-                                     priv->text + priv->select_info->selection_anchor);
-
-  return 0;
-}
-
 /**
  * gtk_label_set_lines:
  * @label: a #GtkLabel
diff --git a/gtk/gtklabelprivate.h b/gtk/gtklabelprivate.h
index f99c50fca5..f12e771c5f 100644
--- a/gtk/gtklabelprivate.h
+++ b/gtk/gtklabelprivate.h
@@ -27,7 +27,6 @@ G_BEGIN_DECLS
 void _gtk_label_mnemonics_visible_apply_recursively (GtkWidget *widget,
                                                      gboolean   mnemonics_visible);
 gint _gtk_label_get_cursor_position (GtkLabel *label);
-gint _gtk_label_get_selection_bound (GtkLabel *label);
 
 gint         _gtk_label_get_n_links     (GtkLabel *label);
 gint         _gtk_label_get_link_at     (GtkLabel *label,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]