[evolution] em-formatter: Remove unneeded attachment-expander button's 'data' attribute

[Milan Crha <mcrha src gnome org>]

commit 93b56ca40f62fbe1acd623a93b99e71cdd60409a
Author: Milan Crha <mcrha redhat com>
Date:   Thu Apr 9 12:14:38 2020 +0200

    em-formatter: Remove unneeded attachment-expander button's 'data' attribute
    
    The 'data' attribute contained HTML code, which had been used a bit later
    in the HTML structure and, more importantly, it was not accessed anywhere,
    thus it only made the HTML code larger with no gain. Also, the attribute
    value could cause HTML structure breakage, when the 'data' attribute
    contained double quotes.

 src/em-format/e-mail-formatter-attachment.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/em-format/e-mail-formatter-attachment.c b/src/em-format/e-mail-formatter-attachment.c
index 9a186618d7..a91871475a 100644
--- a/src/em-format/e-mail-formatter-attachment.c
+++ b/src/em-format/e-mail-formatter-attachment.c
@@ -260,7 +260,7 @@ emfe_attachment_format (EMailFormatterExtension *extension,
                "<table width=\"100%%\" border=\"0\" style=\"border-spacing: 0px\">"
                "<tr valign=\"middle\">"
                "<td align=\"left\" width=\"1px\" style=\"white-space:pre;\">"
-               "<button type=\"button\" class=\"attachment-expander\" id=\"%s\" value=\"%p\" data=\"%s\" 
style=\"vertical-align:middle; margin:0px;\">"
+               "<button type=\"button\" class=\"attachment-expander\" id=\"%s\" value=\"%p\" 
style=\"vertical-align:middle; margin:0px;\">"
                "<img id=\"attachment-expander-img-%p\" src=\"gtk-stock://%s?size=%d\" width=\"%dpx\" 
height=\"%dpx\" style=\"vertical-align:middle;\">"
                "<img src=\"%s\" width=\"%dpx\" height=\"%dpx\" style=\"vertical-align:middle;\">"
                "</button>"
@@ -268,7 +268,7 @@ emfe_attachment_format (EMailFormatterExtension *extension,
                "<img src=\"gtk-stock://x-evolution-arrow-down?size=%d\" width=\"%dpx\" height=\"%dpx\" 
style=\"vertical-align:middle;\">"
                "</button>"
                "</td><td align=\"left\">%s</td></tr>",
-               part_id, attachment_ptr, html, attachment_ptr,
+               part_id, attachment_ptr, attachment_ptr,
                e_mail_part_should_show_inline (part) ? "go-down" : e_mail_part_attachment_get_expandable 
(empa) ? "go-next" : "go-top",
                GTK_ICON_SIZE_BUTTON, icon_width, icon_height,
                icon_uri, icon_width, icon_height,