[gnome-shell] js: Account for promisified call() method
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] js: Account for promisified call() method
- Date: Fri, 3 Apr 2020 02:08:16 +0000 (UTC)
commit 1666fa195df75afe8d52f1ddd57ce7564dc8b387
Author: Florian Müllner <fmuellner gnome org>
Date: Thu Dec 19 20:50:37 2019 +0100
js: Account for promisified call() method
A promisified method expects the callback parameter to be either
a function (in which case the original method is called normally)
or omitted altogether (in which case a Promise is returned).
The call to open application details in Software does neither and
passes null instead, which will result in a warning (because no
function argument means a promise will be used, but not omitting
the parameter means we end up with too many arguments).
https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2551
js/ui/appDisplay.js | 2 +-
js/ui/panel.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 654afc56b6..e13d5f7b92 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -2561,7 +2561,7 @@ var AppIconMenu = class AppIconMenu extends PopupMenu.PopupMenu {
'org.gtk.Actions', 'Activate',
new GLib.Variant.new(
'(sava{sv})', ['details', [args], null]),
- null, 0, -1, null, null);
+ null, 0, -1, null);
Main.overview.hide();
});
}
diff --git a/js/ui/panel.js b/js/ui/panel.js
index d1c314c05b..c2e0f00d3a 100644
--- a/js/ui/panel.js
+++ b/js/ui/panel.js
@@ -99,7 +99,7 @@ class AppMenu extends PopupMenu.PopupMenu {
'/org/gnome/Software',
'org.gtk.Actions', 'Activate',
new GLib.Variant('(sava{sv})', ['details', [args], null]),
- null, 0, -1, null, null);
+ null, 0, -1, null);
});
this.addMenuItem(new PopupMenu.PopupSeparatorMenuItem());
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]