[gimp/gimp-2-10] app: no generic comment when no revision comment set.



commit 1b14b13e4044e5a0a0d29aa4d32ff8f0e4a8a702
Author: Jehan <jehan girinstud io>
Date:   Wed Apr 1 16:41:58 2020 +0200

    app: no generic comment when no revision comment set.
    
    After discussing with Schumaml and Houz on IRC, let's just drop the
    generic comment which may be confusing and is probably unecessary,
    especially now that I write the revision number (present and new ones).
    So let's just assume people understand that they should update, even
    when GIMP version stays the same (this was the case I was the most wary
    about, that people think the notification is an error as since they have
    the last version, they don't have to update GIMP).
    
    I hesitated to at least leave just the simple "It is recommended to
    update." sentence but after much hesitation, let's go with no generic
    comment at all. The download button by itself should suffice.
    
    Of course, when a specific revision comment is set in
    gimp_versions.json, it is still displayed.
    
    (cherry picked from commit 56ffa2fd110281eaa84b3faaf077b8efe1846bb0)

 app/dialogs/about-dialog.c | 7 -------
 1 file changed, 7 deletions(-)
---
diff --git a/app/dialogs/about-dialog.c b/app/dialogs/about-dialog.c
index 18c9e0585a..dd9770d5db 100644
--- a/app/dialogs/about-dialog.c
+++ b/app/dialogs/about-dialog.c
@@ -370,18 +370,11 @@ about_dialog_add_update (GimpAboutDialog *dialog,
                * markups in your translation. */
               comment = g_strdup_printf (_("<u>Release comment</u>: <i>%s</i>"), 
config->last_release_comment);
             }
-          else
-            {
-              comment = g_strdup_printf ("<i>%s</i>",
-                                         _("Even though you use the last version, it is recommended to 
reinstall.\n"
-                                           "New revisions come with package fixes."));
-            }
         }
       else
         {
           text = g_strdup_printf (_("Download GIMP %s (released on %s)\n"),
                                   config->last_known_release, date);
-          comment = g_strdup ("It is recommended to update.");
         }
       gtk_label_set_text (GTK_LABEL (button_label), text);
       g_free (text);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]