[nautilus/wip/oholy/properties-window-critical-fix: 2/3] properties-window: Fix crashes when opened multiple times



commit ff8e7935580a98f0853988952f4419f46b6e640b
Author: Ondrej Holy <oholy redhat com>
Date:   Thu Sep 26 11:07:35 2019 +0200

    properties-window: Fix crashes when opened multiple times
    
    Nautilus crashes with segmentation fault when closing the properties dialog
    after it has been opened mutliple times for the same file. This can't be
    reproduced over Nautilus as it uses modal dialogs, however, it can be simply
    reproduced over the Desktop Icons extension. Let's check the pending_key
    variable before used to be sure it is not NULL to fix this crashes.

 src/nautilus-properties-window.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
---
diff --git a/src/nautilus-properties-window.c b/src/nautilus-properties-window.c
index a8b403924..494077591 100644
--- a/src/nautilus-properties-window.c
+++ b/src/nautilus-properties-window.c
@@ -5291,7 +5291,10 @@ remove_pending (StartupData *startup_data,
         eel_timed_wait_stop
             (cancel_create_properties_window_callback, startup_data);
     }
-    g_hash_table_remove (pending_lists, startup_data->pending_key);
+    if (startup_data->pending_key != NULL)
+    {
+        g_hash_table_remove (pending_lists, startup_data->pending_key);
+    }
 }
 
 static gboolean


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]