[jhbuild/more-py3-fixes: 3/6] extdeps: fix py3 error when passing "--all-modules"



commit ce54107eb4d6d8585d3571b93a4d95cf3fc9be99
Author: Christoph Reiter <reiter christoph gmail com>
Date:   Tue Sep 24 18:36:17 2019 +0200

    extdeps: fix py3 error when passing "--all-modules"
    
    The module list gets sorted later on but dict.values() doesn't
    return a list with Python3, so sorting errors out.
    Convert it to a list first.

 jhbuild/commands/extdeps.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/jhbuild/commands/extdeps.py b/jhbuild/commands/extdeps.py
index 6eb14745..bb4e8e96 100644
--- a/jhbuild/commands/extdeps.py
+++ b/jhbuild/commands/extdeps.py
@@ -87,7 +87,7 @@ class cmd_extdeps(Command):
         config.partial_build = False
         self.module_set = jhbuild.moduleset.load(config)
         if options.list_all_modules:
-            module_list = self.module_set.modules.values()
+            module_list = list(self.module_set.modules.values())
         else:
             module_list = self.module_set.get_module_list(args or config.modules, config.skip)
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]