[metacity] xrender: fix shadow regression



commit 569609a0af1a8c75d543cdc658d83a5c52015abc
Author: Alberts Muktupāvels <alberts muktupavels gmail com>
Date:   Mon Sep 23 23:43:09 2019 +0300

    xrender: fix shadow regression
    
    Commit 8b0ed193cfa7 introduced regression - unmaximized window does
    not have a shadow. Update needs_shadow in sync_window_geometry to
    make sure we have correct state when calling win_extents that will
    recreate shadow if needed.

 src/compositor/meta-compositor-xrender.c | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)
---
diff --git a/src/compositor/meta-compositor-xrender.c b/src/compositor/meta-compositor-xrender.c
index 747912d2..e06f4816 100644
--- a/src/compositor/meta-compositor-xrender.c
+++ b/src/compositor/meta-compositor-xrender.c
@@ -2783,26 +2783,12 @@ static void
 meta_compositor_xrender_maximize_window (MetaCompositor *compositor,
                                          MetaWindow     *window)
 {
-  MetaCompositorXRender *xrender = META_COMPOSITOR_XRENDER (compositor);
-  MetaCompWindow *cw = find_comp_window_by_window (xrender, window);
-
-  if (!cw)
-    return;
-
-  cw->needs_shadow = window_has_shadow (xrender, cw);
 }
 
 static void
 meta_compositor_xrender_unmaximize_window (MetaCompositor *compositor,
                                            MetaWindow     *window)
 {
-  MetaCompositorXRender *xrender = META_COMPOSITOR_XRENDER (compositor);
-  MetaCompWindow *cw = find_comp_window_by_window (xrender, window);
-
-  if (!cw)
-    return;
-
-  cw->needs_shadow = window_has_shadow (xrender, cw);
 }
 
 static void
@@ -2836,6 +2822,8 @@ meta_compositor_xrender_sync_window_geometry (MetaCompositor *compositor,
   if (cw == NULL)
     return;
 
+  cw->needs_shadow = window_has_shadow (xrender, cw);
+
   meta_error_trap_push (window->display);
 
   old_rect = cw->rect;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]