[orca] Revert "Always call handleTextSelectionChange() on descendants"



commit 67c7ae013ef74bc11a257c28e4586ad5c270a819
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Mon Sep 23 17:18:47 2019 +0200

    Revert "Always call handleTextSelectionChange() on descendants"
    
    This reverts commit 5233b3562cce9f26e9d2296dfac616e8f94ef9e3.
    
    It introduced unwanted chattiness.

 src/orca/scripts/web/script_utilities.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
---
diff --git a/src/orca/scripts/web/script_utilities.py b/src/orca/scripts/web/script_utilities.py
index 017072965..374c000bb 100644
--- a/src/orca/scripts/web/script_utilities.py
+++ b/src/orca/scripts/web/script_utilities.py
@@ -1783,7 +1783,10 @@ class Utilities(script_utilities.Utilities):
         handled = False
         descendants = self.findAllDescendants(obj, self.hasPresentableText)
         for descendant in descendants:
-            handled = super().handleTextSelectionChange(descendant) or handled
+            if handled:
+                super().updateCachedTextSelection(descendant)
+            else:
+                handled = handled or super().handleTextSelectionChange(descendant)
 
         return handled
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]