[gnome-control-center] network: Fix a crash when opening connection editor



commit 3316f5186662063ff6a24702a0421b8f625d0f58
Author: Mohammed Sadiq <sadiq sadiqpk org>
Date:   Mon Sep 23 17:42:37 2019 +0530

    network: Fix a crash when opening connection editor

 panels/network/connection-editor/ce-page.c | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)
---
diff --git a/panels/network/connection-editor/ce-page.c b/panels/network/connection-editor/ce-page.c
index 9cc9e1b4b..4059ad328 100644
--- a/panels/network/connection-editor/ce-page.c
+++ b/panels/network/connection-editor/ce-page.c
@@ -295,17 +295,12 @@ ce_page_complete_init (CEPage      *page,
        }
 
        /* Update the connection with the new secrets */
-       if (nm_connection_update_secrets (page->connection,
-                                         setting_name,
-                                         secrets,
-                                         &update_error)) {
-               g_warning ("Couldn't update secrets: %s", update_error->message);
-               /* Success */
-               emit_initialized (page, NULL);
-               return;
-       }
+       if (!nm_connection_update_secrets (page->connection,
+                                           setting_name,
+                                           secrets,
+                                           &update_error))
+                g_warning ("Couldn't update secrets: %s", update_error->message);
 
-       g_warning ("Failed to update connection secrets due to an unknown error.");
        emit_initialized (page, NULL);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]