[gnome-keyring/wip/dueno/ubsan: 1/3] egg: Fix undefined behavior on excessive left shift



commit f18417eac444bc447de796b4a7fd76ffeda0ec04
Author: Daiki Ueno <dueno src gnome org>
Date:   Mon Sep 16 15:26:10 2019 +0200

    egg: Fix undefined behavior on excessive left shift

 egg/egg-buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/egg/egg-buffer.c b/egg/egg-buffer.c
index fd0aca27..f20588ff 100644
--- a/egg/egg-buffer.c
+++ b/egg/egg-buffer.c
@@ -321,7 +321,7 @@ egg_buffer_encode_uint32 (unsigned char* buf, uint32_t val)
 uint32_t
 egg_buffer_decode_uint32 (unsigned char* ptr)
 {
-       uint32_t val = ptr[0] << 24 | ptr[1] << 16 | ptr[2] << 8 | ptr[3];
+       uint32_t val = (uint32_t) ptr[0] << 24 | ptr[1] << 16 | ptr[2] << 8 | ptr[3];
        return val;
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]