[orca] Always call handleTextSelectionChange() on descendants



commit 5233b3562cce9f26e9d2296dfac616e8f94ef9e3
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Fri Sep 13 16:51:44 2019 +0200

    Always call handleTextSelectionChange() on descendants
    
    When we get the selection-change on a parent of embedded children,
    and the selection change spans multiple objects, we want to present
    all the changes; not just update the cached selection.

 src/orca/scripts/web/script_utilities.py | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
---
diff --git a/src/orca/scripts/web/script_utilities.py b/src/orca/scripts/web/script_utilities.py
index 374c000bb..017072965 100644
--- a/src/orca/scripts/web/script_utilities.py
+++ b/src/orca/scripts/web/script_utilities.py
@@ -1783,10 +1783,7 @@ class Utilities(script_utilities.Utilities):
         handled = False
         descendants = self.findAllDescendants(obj, self.hasPresentableText)
         for descendant in descendants:
-            if handled:
-                super().updateCachedTextSelection(descendant)
-            else:
-                handled = handled or super().handleTextSelectionChange(descendant)
+            handled = super().handleTextSelectionChange(descendant) or handled
 
         return handled
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]