[grilo-plugins/wip/jfelder/tracker-musicbrainz-external-reference: 6/7] tracker: Remove musicbrainz keys from the list of writable keys

[Jean Felder <jfelder src gnome org>]

commit af7d6b62bf1881e5f6e3dbb5fb3f0a1814855390
Author: Jean Felder <jfelder src gnome org>
Date:   Wed Sep 11 20:11:07 2019 +0200

    tracker: Remove musicbrainz keys from the list of writable keys
    
    MusicBrainz metadata have been added to Tracker ontology during the
    2.3 development cycle. The initial idea was to extend nmm:MusicPiece
    to add new MusicBrainz properties. This solution was not generic
    enough (it did not allow to handle other online services). Finally, it
    has been decided to introduce tracker:ExternalReference to handle
    MusicBrainz (and any ony online service).
    
    This plugin can only update a property of a nmm:MusicPiece (for
    example its title). However, with the selected ontology, the
    musicbrainz keys are not a property of a nmm:MusicPiece but an
    external resource associated with a nmm:MusicPiece. Therefore,
    GRL_METADATA_KEY_MB_RECORDING_ID and GRL_METADATA_KEY_MB_TRACK_ID keys
    cannot be writable.
    
    The next commit will update the mapping to use the correct ontology:
    tracker:ExternalReference.

 src/tracker/grl-tracker-source-api.c |  2 --
 src/tracker/grl-tracker-utils.c      | 18 ++++++++----------
 2 files changed, 8 insertions(+), 12 deletions(-)
---
diff --git a/src/tracker/grl-tracker-source-api.c b/src/tracker/grl-tracker-source-api.c
index 382165e9..5abf3a05 100644
--- a/src/tracker/grl-tracker-source-api.c
+++ b/src/tracker/grl-tracker-source-api.c
@@ -668,8 +668,6 @@ grl_tracker_source_writable_keys (GrlSource *source)
                                       GRL_METADATA_KEY_LAST_PLAYED,
                                       GRL_METADATA_KEY_LAST_POSITION,
                                       GRL_METADATA_KEY_FAVOURITE,
-                                      GRL_METADATA_KEY_MB_TRACK_ID,
-                                      GRL_METADATA_KEY_MB_RECORDING_ID,
                                       GRL_METADATA_KEY_TITLE,
                                       GRL_METADATA_KEY_TRACK_NUMBER,
                                       GRL_METADATA_KEY_CREATION_DATE,
diff --git a/src/tracker/grl-tracker-utils.c b/src/tracker/grl-tracker-utils.c
index eb012d42..94701100 100644
--- a/src/tracker/grl-tracker-utils.c
+++ b/src/tracker/grl-tracker-utils.c
@@ -300,22 +300,20 @@ grl_tracker_setup_key_mappings (void)
                       "nfo:duration(?urn)",
                       "audio");
 
-  insert_key_mapping_with_setter (GRL_METADATA_KEY_MB_TRACK_ID,
-                                  "nmm:mbTrackID",
-                                  "nmm:mbTrackID(?urn)",
-                                  "audio",
-                                  set_string_metadata_keys);
+  insert_key_mapping (GRL_METADATA_KEY_MB_TRACK_ID,
+                      "nmm:mbTrackID",
+                      "nmm:mbTrackID(?urn)",
+                      "audio");
 
   insert_key_mapping (GRL_METADATA_KEY_MB_ARTIST_ID,
                       "nmm:mbArtistID",
                       "nmm:mbArtistID(?urn)",
                       "audio");
 
-  insert_key_mapping_with_setter (GRL_METADATA_KEY_MB_RECORDING_ID,
-                                  "nmm:mbRecordingID",
-                                  "nmm:mbRecordingID(?urn)",
-                                  "audio",
-                                  set_string_metadata_keys);
+  insert_key_mapping (GRL_METADATA_KEY_MB_RECORDING_ID,
+                      "nmm:mbRecordingID",
+                      "nmm:mbRecordingID(?urn)",
+                      "audio");
 
   insert_key_mapping (GRL_METADATA_KEY_MB_RELEASE_ID,
                       "nmm:mbReleaseID",