[gnome-control-center] printers: Connect signals in swapped form



commit 2c28987e4152a8d4df46df02d8ab2df89bf423a2
Author: Robert Ancell <robert ancell canonical com>
Date:   Fri Nov 23 15:14:13 2018 +1300

    printers: Connect signals in swapped form

 panels/printers/pp-details-dialog.c  | 13 ++++---------
 panels/printers/pp-details-dialog.ui |  8 ++++----
 2 files changed, 8 insertions(+), 13 deletions(-)
---
diff --git a/panels/printers/pp-details-dialog.c b/panels/printers/pp-details-dialog.c
index 524cb90d1..d6d1d3aee 100644
--- a/panels/printers/pp-details-dialog.c
+++ b/panels/printers/pp-details-dialog.c
@@ -63,10 +63,8 @@ struct _PpDetailsDialog {
 G_DEFINE_TYPE (PpDetailsDialog, pp_details_dialog, GTK_TYPE_DIALOG)
 
 static void
-printer_name_changed (GtkEditable *editable,
-                      gpointer     user_data)
+printer_name_changed (PpDetailsDialog *self)
 {
-  PpDetailsDialog *self = (PpDetailsDialog *) user_data;
   const gchar *name;
   g_autofree gchar *title = NULL;
 
@@ -128,8 +126,7 @@ get_ppd_names_cb (PPDName     **names,
 }
 
 static void
-search_for_drivers (GtkButton       *button,
-                    PpDetailsDialog *self)
+search_for_drivers (PpDetailsDialog *self)
 {
   gtk_stack_set_visible_child_name (self->printer_model_stack, "loading");
   gtk_widget_set_sensitive (self->search_for_drivers_button, FALSE);
@@ -195,8 +192,7 @@ get_all_ppds_async_cb (PPDList  *ppds,
 }
 
 static void
-select_ppd_in_dialog (GtkButton       *button,
-                      PpDetailsDialog *self)
+select_ppd_in_dialog (PpDetailsDialog *self)
 {
   g_autofree gchar *device_id = NULL;
   g_autofree gchar *manufacturer = NULL;
@@ -244,8 +240,7 @@ select_ppd_in_dialog (GtkButton       *button,
 }
 
 static void
-select_ppd_manually (GtkButton       *button,
-                     PpDetailsDialog *self)
+select_ppd_manually (PpDetailsDialog *self)
 {
   GtkFileFilter *filter;
   GtkWidget     *dialog;
diff --git a/panels/printers/pp-details-dialog.ui b/panels/printers/pp-details-dialog.ui
index 71683990b..97f331018 100644
--- a/panels/printers/pp-details-dialog.ui
+++ b/panels/printers/pp-details-dialog.ui
@@ -54,7 +54,7 @@
                 <property name="visible">True</property>
                 <property name="halign">fill</property>
                 <property name="width_request">320</property>
-                <signal name="changed" handler="printer_name_changed"/>
+                <signal name="changed" handler="printer_name_changed" object="PpDetailsDialog" 
swapped="yes"/>
               </object>
               <packing>
                 <property name="left-attach">1</property>
@@ -188,7 +188,7 @@
                     <property name="visible">True</property>
                     <property name="label" translatable="yes">Search for Drivers</property>
                     <property name="halign">fill</property>
-                    <signal name="clicked" handler="search_for_drivers"/>
+                    <signal name="clicked" handler="search_for_drivers" object="PpDetailsDialog" 
swapped="yes"/>
                   </object>
                 </child>
 
@@ -197,7 +197,7 @@
                     <property name="visible">True</property>
                     <property name="label" translatable="yes">Select from Database…</property>
                     <property name="halign">fill</property>
-                    <signal name="clicked" handler="select_ppd_in_dialog"/>
+                    <signal name="clicked" handler="select_ppd_in_dialog" object="PpDetailsDialog" 
swapped="yes"/>
                   </object>
                 </child>
 
@@ -206,7 +206,7 @@
                     <property name="visible">True</property>
                     <property name="label" translatable="yes">Install PPD File…</property>
                     <property name="halign">fill</property>
-                    <signal name="clicked" handler="select_ppd_manually"/>
+                    <signal name="clicked" handler="select_ppd_manually" object="PpDetailsDialog" 
swapped="yes"/>
                   </object>
                 </child>
               </object>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]