[gimp] libgimp: fix crash introduced in commit bfe4a2f9



commit 8ef87b09222f4044bb8f25052710fa6c3c3dd51a
Author: Michael Natterer <mitch gimp org>
Date:   Fri Sep 6 17:24:33 2019 +0200

    libgimp: fix crash introduced in commit bfe4a2f9
    
    Freeing stuff is good, but freeing twice is not so good.

 libgimp/gimpgpparams-body.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
---
diff --git a/libgimp/gimpgpparams-body.c b/libgimp/gimpgpparams-body.c
index 1556138019..3d7d938c8c 100644
--- a/libgimp/gimpgpparams-body.c
+++ b/libgimp/gimpgpparams-body.c
@@ -982,9 +982,10 @@ _gimp_gp_params_free (GPParam  *params,
 
         case GP_PARAM_TYPE_PARASITE:
           if (full_copy)
-            g_free (params[i].data.d_parasite.name);
-          if (params[i].data.d_parasite.data)
-            g_free (params[i].data.d_parasite.data);
+            {
+              g_free (params[i].data.d_parasite.name);
+              g_free (params[i].data.d_parasite.data);
+            }
           break;
 
         case GP_PARAM_TYPE_PARAM_DEF:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]