[rhythmbox] rhythmdb: only set bitrate for non-lossless files



commit 108aee090091c9d9c482341458c7a5cca7574909
Author: Jonathan Matthew <jonathan d14n org>
Date:   Mon Sep 2 20:38:39 2019 +1000

    rhythmdb: only set bitrate for non-lossless files
    
    Bitrate isn't terribly meaningful otherwise, and we use bitrate != 0
    as a shortcut for testing if a file is lossily encoded, so things work
    better if lossless files don't have it set.
    
    Closes #1696

 rhythmdb/rhythmdb.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)
---
diff --git a/rhythmdb/rhythmdb.c b/rhythmdb/rhythmdb.c
index c00798392..fa93ecc92 100644
--- a/rhythmdb/rhythmdb.c
+++ b/rhythmdb/rhythmdb.c
@@ -1996,13 +1996,15 @@ set_props_from_metadata (RhythmDB *db,
                g_value_unset (&val);
        }
 
-       /* bitrate */
-       if (rb_metadata_get (metadata,
-                            RB_METADATA_FIELD_BITRATE,
-                            &val)) {
-               rhythmdb_entry_set_internal (db, entry, TRUE,
-                                            RHYTHMDB_PROP_BITRATE, &val);
-               g_value_unset (&val);
+       /* bitrate (only set for non-lossless media types) */
+       if (!rb_gst_media_type_is_lossless (media_type)) {
+               if (rb_metadata_get (metadata,
+                                    RB_METADATA_FIELD_BITRATE,
+                                    &val)) {
+                       rhythmdb_entry_set_internal (db, entry, TRUE,
+                                                    RHYTHMDB_PROP_BITRATE, &val);
+                       g_value_unset (&val);
+               }
        }
 
        /* date */


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]