[tracker-miners/wip/jfelder/external-reference-fixes: 3/4] libtracker-extract: Set the correct uri for tracker:ExternalReference



commit 1aa06a0b2c1d701fa84084c058376827c25d3a16
Author: Jean Felder <jfelder src gnome org>
Date:   Sun Sep 1 14:58:23 2019 +0200

    libtracker-extract: Set the correct uri for tracker:ExternalReference
    
    It needs to starts with "urn" instead of "tracker".

 src/libtracker-extract/tracker-resource-helpers.c              |  2 +-
 .../test-extraction-data/audio/audio-test-1.expected.json      | 10 +++++-----
 .../test-extraction-data/audio/audio-test-2.expected.json      | 10 +++++-----
 .../audio/audio-test-vorbis-extractor.expected.json            | 10 +++++-----
 4 files changed, 16 insertions(+), 16 deletions(-)
---
diff --git a/src/libtracker-extract/tracker-resource-helpers.c 
b/src/libtracker-extract/tracker-resource-helpers.c
index 53a287ecb..ff75a344a 100644
--- a/src/libtracker-extract/tracker-resource-helpers.c
+++ b/src/libtracker-extract/tracker-resource-helpers.c
@@ -161,7 +161,7 @@ tracker_extract_new_external_reference (const char *source_uri,
 
        g_return_val_if_fail (source_uri != NULL && identifier != NULL, NULL);
 
-       uri = tracker_sparql_escape_uri_printf ("tracker:ExternalReference:%s", source_uri);
+       uri = tracker_sparql_escape_uri_printf ("urn:ExternalReference:%s", source_uri);
 
        external_reference = tracker_resource_new (uri);
        tracker_resource_set_uri (external_reference, "rdf:type", "tracker:ExternalReference");
diff --git a/tests/functional-tests/test-extraction-data/audio/audio-test-1.expected.json 
b/tests/functional-tests/test-extraction-data/audio/audio-test-1.expected.json
index ed086999d..ff550c464 100644
--- a/tests/functional-tests/test-extraction-data/audio/audio-test-1.expected.json
+++ b/tests/functional-tests/test-extraction-data/audio/audio-test-1.expected.json
@@ -21,7 +21,7 @@
             "nmm:artistName": "AbBaby",
             "tracker:hasExternalReference": [
                 {
-                    "@id": "tracker:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FArtist",
+                    "@id": "urn:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FArtist",
                     "@type": "tracker:ExternalReference",
                     "tracker:referenceSource": "https://musicbrainz.org/doc/Artist";,
                     "tracker:referenceIdentifier": "234561"
@@ -33,13 +33,13 @@
             "nie:title": "SinCos",
             "tracker:hasExternalReference": [
                 {
-                    "@id": "tracker:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRelease",
+                    "@id": "urn:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRelease",
                     "@type": "tracker:ExternalReference",
                     "tracker:referenceSource": "https://musicbrainz.org/doc/Release";,
                     "tracker:referenceIdentifier": "345612"
                 },
                 {
-                    "@id": "tracker:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRelease_Group",
+                    "@id": "urn:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRelease_Group",
                     "@type": "tracker:ExternalReference",
                     "tracker:referenceSource": "https://musicbrainz.org/doc/Release_Group";,
                     "tracker:referenceIdentifier": "561234"
@@ -48,13 +48,13 @@
         },
         "tracker:hasExternalReference": [
             {
-                "@id": "tracker:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRecording",
+                "@id": "urn:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRecording",
                 "@type": "tracker:ExternalReference",
                 "tracker:referenceSource": "https://musicbrainz.org/doc/Recording";,
                 "tracker:referenceIdentifier": "456123"
             },
             {
-                "@id": "tracker:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FTrack",
+                "@id": "urn:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FTrack",
                 "@type": "tracker:ExternalReference",
                 "tracker:referenceSource": "https://musicbrainz.org/doc/Track";,
                 "tracker:referenceIdentifier": "123456"
diff --git a/tests/functional-tests/test-extraction-data/audio/audio-test-2.expected.json 
b/tests/functional-tests/test-extraction-data/audio/audio-test-2.expected.json
index 988fdeb4e..ee70bf7da 100644
--- a/tests/functional-tests/test-extraction-data/audio/audio-test-2.expected.json
+++ b/tests/functional-tests/test-extraction-data/audio/audio-test-2.expected.json
@@ -19,7 +19,7 @@
             "nmm:artistName": "Anna Abreu",
             "tracker:hasExternalReference": [
                 {
-                    "@id": "tracker:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FArtist",
+                    "@id": "urn:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FArtist",
                     "@type": "tracker:ExternalReference",
                     "tracker:referenceSource": "https://musicbrainz.org/doc/Artist";,
                     "tracker:referenceIdentifier": "234561"
@@ -30,13 +30,13 @@
             "@type": "nmm:MusicAlbum",
             "tracker:hasExternalReference": [
                 {
-                    "@id": "tracker:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRelease",
+                    "@id": "urn:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRelease",
                     "@type": "tracker:ExternalReference",
                     "tracker:referenceSource": "https://musicbrainz.org/doc/Release";,
                     "tracker:referenceIdentifier": "345612"
                 },
                 {
-                    "@id": "tracker:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRelease_Group",
+                    "@id": "urn:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRelease_Group",
                     "@type": "tracker:ExternalReference",
                     "tracker:referenceSource": "https://musicbrainz.org/doc/Release_Group";,
                     "tracker:referenceIdentifier": "561234"
@@ -45,13 +45,13 @@
         },
         "tracker:hasExternalReference": [
             {
-                "@id": "tracker:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRecording",
+                "@id": "urn:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRecording",
                 "@type": "tracker:ExternalReference",
                 "tracker:referenceSource": "https://musicbrainz.org/doc/Recording";,
                 "tracker:referenceIdentifier": "456123"
             },
             {
-                "@id": "tracker:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FTrack",
+                "@id": "urn:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FTrack",
                 "@type": "tracker:ExternalReference",
                 "tracker:referenceSource": "https://musicbrainz.org/doc/Track";,
                 "tracker:referenceIdentifier": "123456"
diff --git a/tests/functional-tests/test-extraction-data/audio/audio-test-vorbis-extractor.expected.json 
b/tests/functional-tests/test-extraction-data/audio/audio-test-vorbis-extractor.expected.json
index 966b62e36..fbcda2441 100644
--- a/tests/functional-tests/test-extraction-data/audio/audio-test-vorbis-extractor.expected.json
+++ b/tests/functional-tests/test-extraction-data/audio/audio-test-vorbis-extractor.expected.json
@@ -16,7 +16,7 @@
             "@type": "nmm:Artist",
             "nmm:artistName": "AbBaby",
             "tracker:hasExternalReference": {
-                "@id": "tracker:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FArtist",
+                "@id": "urn:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FArtist",
                 "@type": "tracker:ExternalReference",
                 "tracker:referenceSource": "https://musicbrainz.org/doc/Artist";,
                 "tracker:referenceIdentifier": "234561"
@@ -27,13 +27,13 @@
             "nie:title": "SinCos",
             "tracker:hasExternalReference": [
                 {
-                    "@id": "tracker:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRelease",
+                    "@id": "urn:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRelease",
                     "@type": "tracker:ExternalReference",
                     "tracker:referenceSource": "https://musicbrainz.org/doc/Release";,
                     "tracker:referenceIdentifier": "345612"
                 },
                 {
-                    "@id": "tracker:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRelease_Group",
+                    "@id": "urn:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRelease_Group",
                     "@type": "tracker:ExternalReference",
                     "tracker:referenceSource": "https://musicbrainz.org/doc/Release_Group";,
                     "tracker:referenceIdentifier": "561234"
@@ -42,13 +42,13 @@
         },
         "tracker:hasExternalReference": [
             {
-                "@id": "tracker:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRecording",
+                "@id": "urn:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FRecording",
                 "@type": "tracker:ExternalReference",
                 "tracker:referenceSource": "https://musicbrainz.org/doc/Recording";,
                 "tracker:referenceIdentifier": "456123"
             },
             {
-                "@id": "tracker:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FTrack",
+                "@id": "urn:ExternalReference:https:%2F%2Fmusicbrainz.org%2Fdoc%2FTrack",
                 "@type": "tracker:ExternalReference",
                 "tracker:referenceSource": "https://musicbrainz.org/doc/Track";,
                 "tracker:referenceIdentifier": "123456"


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]