[pango/no-shape-attrs: 1/4] Go back to ignoring underlines for itemization



commit 511ebfccfd6ca54611d90a5c0ab1f19c8e714422
Author: Matthias Clasen <mclasen redhat com>
Date:   Mon Oct 28 20:30:21 2019 -0400

    Go back to ignoring underlines for itemization
    
    This is what we used to do, and without it, we
    lose kerning beween underlined and non-underlined
    characters, which is most noticable with mnemonic
    underlines.
    
    Fixes: https://gitlab.gnome.org/GNOME/pango/issues/426

 pango/pango-layout.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
---
diff --git a/pango/pango-layout.c b/pango/pango-layout.c
index 2863894c..db016614 100644
--- a/pango/pango-layout.c
+++ b/pango/pango-layout.c
@@ -4085,12 +4085,9 @@ affects_itemization (PangoAttribute *attr,
     case PANGO_ATTR_ABSOLUTE_SIZE:
     case PANGO_ATTR_GRAVITY:
     case PANGO_ATTR_GRAVITY_HINT:
-    /* These are part of ItemProperties, so need to break runs */
-    case PANGO_ATTR_SHAPE:
-    case PANGO_ATTR_RISE:
-    case PANGO_ATTR_UNDERLINE:
-    case PANGO_ATTR_STRIKETHROUGH:
+    /* These need to be constant across runs */
     case PANGO_ATTR_LETTER_SPACING:
+    case PANGO_ATTR_SHAPE:
       return TRUE;
     default:
       return FALSE;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]