[glib/param-value-default: 3/4] Do not validate a GValue initialized with the default



commit f7824da85f2870a7deef7374f9fcf86a6a6a47cf
Author: Emmanuele Bassi <ebassi gnome org>
Date:   Sat Oct 26 14:04:26 2019 +0100

    Do not validate a GValue initialized with the default
    
    There's really no point in going through validation, if we know the
    value we're validating is coming straight from the GParamSpec.

 gobject/gparamspecs.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/gobject/gparamspecs.c b/gobject/gparamspecs.c
index 5d15c26e1..a110281ca 100644
--- a/gobject/gparamspecs.c
+++ b/gobject/gparamspecs.c
@@ -912,8 +912,11 @@ param_value_array_validate (GParamSpec *pspec,
                  g_param_value_set_default (element_spec, element);
                  changed++;
                }
-             /* validate array value against element_spec */
-             changed += g_param_value_validate (element_spec, element);
+              else
+                {
+                 /* validate array value against element_spec */
+                 changed += g_param_value_validate (element_spec, element);
+                }
            }
        }
     }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]