[vala/staging: 3/3] vala: Don't falsely resolve binary-expression to bool

[Rico Tzschichholz <ricotz src gnome org>]

commit e679740751b4fde1d40103f8a84fba0fed1ff9a2
Author: Rico Tzschichholz <ricotz ubuntu com>
Date:   Thu Oct 24 14:15:56 2019 +0200

    vala: Don't falsely resolve binary-expression to bool
    
    Fixes https://gitlab.gnome.org/GNOME/vala/issues/869

 tests/Makefile.am                                  | 2 ++
 tests/control-semantic/condition-not-boolean.test  | 7 +++++++
 tests/control-semantic/expression-not-boolean.test | 5 +++++
 vala/valabinaryexpression.vala                     | 8 +++++++-
 4 files changed, 21 insertions(+), 1 deletion(-)
---
diff --git a/tests/Makefile.am b/tests/Makefile.am
index b2a740c13..a80d7a27a 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -201,6 +201,8 @@ TESTS = \
        control-semantic/argument-owned-ref.test \
        control-semantic/argument-value-out.test \
        control-semantic/argument-value-ref.test \
+       control-semantic/condition-not-boolean.test \
+       control-semantic/expression-not-boolean.test \
        control-semantic/literal-immutable.test \
        control-semantic/member-incompatible-type.test \
        control-semantic/member-invalid.test \
diff --git a/tests/control-semantic/condition-not-boolean.test 
b/tests/control-semantic/condition-not-boolean.test
new file mode 100644
index 000000000..7ba2130e9
--- /dev/null
+++ b/tests/control-semantic/condition-not-boolean.test
@@ -0,0 +1,7 @@
+Invalid Code
+
+void main () {
+       if (true != false & 0) {
+               assert_not_reached ();
+       }
+}
diff --git a/tests/control-semantic/expression-not-boolean.test 
b/tests/control-semantic/expression-not-boolean.test
new file mode 100644
index 000000000..2be02e98d
--- /dev/null
+++ b/tests/control-semantic/expression-not-boolean.test
@@ -0,0 +1,5 @@
+Invalid Code
+
+void main () {
+       bool foo = true != false & 0;
+}
diff --git a/vala/valabinaryexpression.vala b/vala/valabinaryexpression.vala
index bfabcf5aa..f9b66e377 100644
--- a/vala/valabinaryexpression.vala
+++ b/vala/valabinaryexpression.vala
@@ -511,7 +511,13 @@ public class Vala.BinaryExpression : Expression {
                        left.target_type.nullable = false;
                        right.target_type.nullable = false;
 
-                       value_type = left.target_type.copy ();
+                       // Don't falsely resolve to bool
+                       if (left.value_type.compatible (context.analyzer.bool_type)
+                           && !right.value_type.compatible (context.analyzer.bool_type)) {
+                               value_type = right.target_type.copy ();
+                       } else {
+                               value_type = left.target_type.copy ();
+                       }
                        break;
                case BinaryOperator.AND:
                case BinaryOperator.OR: