[gimp/gimp-2-10] Checking wrong sizeof in gimpmetadata.c



commit c5f597d5c01fa5705fc5dbc9895c2af59ac6752a
Author: Sabri Ünal <libreajans gmail com>
Date:   Sat Oct 19 22:41:21 2019 +0000

    Checking wrong sizeof in gimpmetadata.c
    
    "Buffer 'strdata' is being written before its old content has been used."

 libgimpbase/gimpmetadata.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/libgimpbase/gimpmetadata.c b/libgimpbase/gimpmetadata.c
index 930f5d6ed9..1b3342d064 100644
--- a/libgimpbase/gimpmetadata.c
+++ b/libgimpbase/gimpmetadata.c
@@ -456,7 +456,7 @@ gimp_metadata_add_xmp_history (GimpMetadata *metadata,
 #endif
 
   memset (tagstr, 0, sizeof (tagstr));
-  memset (strdata, 0, sizeof (tagstr));
+  memset (strdata, 0, sizeof (strdata));
 
   g_snprintf (tagstr, sizeof (tagstr), "%s[%d]%s",
               tags[3], id_count, history_tags[4]);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]