[orca] Remove an obsolete hack that is preventing presentation of text selection



commit 8c30da428e5b9f3cfcba1b414369320ab3045d8b
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Fri Oct 18 11:41:18 2019 -0400

    Remove an obsolete hack that is preventing presentation of text selection

 src/orca/script_utilities.py                | 4 ----
 src/orca/scripts/apps/Thunderbird/script.py | 3 ---
 src/orca/scripts/default.py                 | 2 --
 3 files changed, 9 deletions(-)
---
diff --git a/src/orca/script_utilities.py b/src/orca/script_utilities.py
index b85de527a..c0e72149f 100644
--- a/src/orca/script_utilities.py
+++ b/src/orca/script_utilities.py
@@ -5355,10 +5355,6 @@ class Utilities:
         self.updateCachedTextSelection(obj)
         newStart, newEnd, newString = self.getCachedTextSelection(obj)
 
-        # TODO - JD: This may be (now or soon) obsolete.
-        if self._script.pointOfReference.get('lastAutoComplete') == hash(obj):
-            return False
-
         if self._speakTextSelectionState(len(newString)):
             return True
 
diff --git a/src/orca/scripts/apps/Thunderbird/script.py b/src/orca/scripts/apps/Thunderbird/script.py
index b4ff020aa..f19c66ed6 100644
--- a/src/orca/scripts/apps/Thunderbird/script.py
+++ b/src/orca/scripts/apps/Thunderbird/script.py
@@ -173,8 +173,6 @@ class Script(Gecko.Script):
             return
 
         self._lastAutoComplete = ""
-        self.pointOfReference['lastAutoComplete'] = None
-
         obj = event.source
         if self.spellcheck.isAutoFocusEvent(event):
             orca.setLocusOfFocus(event, event.source, False)
@@ -321,7 +319,6 @@ class Script(Gecko.Script):
             if hasSelection or isSystemEvent:
                 speech.speak(event.any_data)
                 self._lastAutoComplete = event.any_data
-                self.pointOfReference['lastAutoComplete'] = hash(obj)
                 return
 
         super().onTextInserted(event)
diff --git a/src/orca/scripts/default.py b/src/orca/scripts/default.py
index 8ab458b5b..560341316 100644
--- a/src/orca/scripts/default.py
+++ b/src/orca/scripts/default.py
@@ -2708,8 +2708,6 @@ class Script(script.Script):
         elif self.utilities.isSelectedTextInsertionEvent(event):
             msg = "DEFAULT: Insertion is also selected"
             debug.println(debug.LEVEL_INFO, msg, True)
-            # TODO - JD: This may be (now or soon) obsolete.
-            self.pointOfReference['lastAutoComplete'] = hash(event.source)
         else:
             msg = "DEFAULT: Not speaking inserted string due to lack of cause"
             debug.println(debug.LEVEL_INFO, msg, True)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]