[gnome-shell] background: Rename Background 'changed' signal to 'bg-changed'
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] background: Rename Background 'changed' signal to 'bg-changed'
- Date: Wed, 16 Oct 2019 15:31:52 +0000 (UTC)
commit c7e0c7eb792fcd665adb9901a1eab1fd6a5bd12d
Author: Marco Trevisan (Treviño) <mail 3v1n0 net>
Date: Sat Jul 13 01:56:12 2019 +0300
background: Rename Background 'changed' signal to 'bg-changed'
Meta.Background has already a 'changed' signal and not to confuse the source
signal with the wrapper one, rename the wrapper class signal into 'bg-changed'.
This will be relevant when we'll inherit from Meta.Background, as signal
emissions from the base class could interfere with the wanted derived class
behavior and with the the grouping of successive changes into a single ::change
emission.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/559
js/ui/background.js | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
---
diff --git a/js/ui/background.js b/js/ui/background.js
index 8432abc75e..b7307e5a45 100644
--- a/js/ui/background.js
+++ b/js/ui/background.js
@@ -300,9 +300,11 @@ var Background = class Background {
this._changedIdleId = GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
this._changedIdleId = 0;
- this.emit('changed');
+ this.emit('bg-changed');
return GLib.SOURCE_REMOVE;
});
+ GLib.Source.set_name_by_id(this._changedIdleId,
+ '[gnome-shell] Background._emitChangedSignal');
}
updateResolution() {
@@ -566,7 +568,7 @@ var BackgroundSource = class BackgroundSource {
// We don't watch changes to settings here,
// instead we rely on Background to watch those
- // and emit 'changed' at the right time
+ // and emit 'bg-changed' at the right time
if (this._overrideImage != null) {
file = Gio.File.new_for_path(this._overrideImage);
@@ -595,7 +597,7 @@ var BackgroundSource = class BackgroundSource {
style: style
});
- background._changedId = background.connect('changed', () => {
+ background._changedId = background.connect('bg-changed', () => {
background.disconnect(background._changedId);
background.destroy();
delete this._backgrounds[monitorIndex];
@@ -766,7 +768,7 @@ var BackgroundManager = class BackgroundManager {
backgroundActor.lower_bottom();
}
- let changeSignalId = background.connect('changed', () => {
+ let changeSignalId = background.connect('bg-changed', () => {
background.disconnect(changeSignalId);
changeSignalId = null;
this._updateBackgroundActor();
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]