[gnome-logs/wip/nielsdg/chainup-finalize] Don't forget to chain up to parent finalize



commit ad423d2d060d7a4ddb4ccec445210dcd17fda6ef
Author: Niels De Graef <nielsdegraef gmail com>
Date:   Tue Oct 15 00:02:15 2019 +0200

    Don't forget to chain up to parent finalize
    
    Forgetting doesn't hurt that much, but it's a tiny memory leak
    nonetheless, so let's fix this.

 src/gl-application.c     | 2 ++
 src/gl-eventviewdetail.c | 2 ++
 src/gl-eventviewlist.c   | 2 ++
 src/gl-eventviewrow.c    | 2 ++
 src/gl-journal.c         | 2 ++
 5 files changed, 10 insertions(+)
---
diff --git a/src/gl-application.c b/src/gl-application.c
index b1c8ff3..c20052c 100644
--- a/src/gl-application.c
+++ b/src/gl-application.c
@@ -251,6 +251,8 @@ gl_application_finalize (GObject *object)
     g_clear_object (&priv->desktop);
     g_clear_object (&priv->settings);
     g_clear_pointer (&priv->monospace_font, g_free);
+
+    G_OBJECT_CLASS (gl_application_parent_class)->finalize (object);
 }
 
 static void
diff --git a/src/gl-eventviewdetail.c b/src/gl-eventviewdetail.c
index 4b43362..6685420 100644
--- a/src/gl-eventviewdetail.c
+++ b/src/gl-eventviewdetail.c
@@ -356,6 +356,8 @@ gl_event_view_detail_finalize (GObject *object)
     GlEventViewDetailPrivate *priv = gl_event_view_detail_get_instance_private (detail);
 
     g_clear_object (&priv->entry);
+
+    G_OBJECT_CLASS (gl_event_view_detail_parent_class)->finalize (object);
 }
 
 static void
diff --git a/src/gl-eventviewlist.c b/src/gl-eventviewlist.c
index c9acd17..d313c7d 100644
--- a/src/gl-eventviewlist.c
+++ b/src/gl-eventviewlist.c
@@ -1030,6 +1030,8 @@ gl_event_view_list_finalize (GObject *object)
     g_clear_object (&priv->journal_model);
     g_clear_pointer (&priv->search_text, g_free);
     g_object_unref (priv->category_sizegroup);
+
+    G_OBJECT_CLASS (gl_event_view_list_parent_class)->finalize (object);
 }
 
 static void
diff --git a/src/gl-eventviewrow.c b/src/gl-eventviewrow.c
index 77bfb66..540105d 100644
--- a/src/gl-eventviewrow.c
+++ b/src/gl-eventviewrow.c
@@ -125,6 +125,8 @@ gl_event_view_row_finalize (GObject *object)
     GlEventViewRowPrivate *priv = gl_event_view_row_get_instance_private (row);
 
     g_clear_object (&priv->entry);
+
+    G_OBJECT_CLASS (gl_event_view_row_parent_class)->finalize (object);
 }
 
 static void
diff --git a/src/gl-journal.c b/src/gl-journal.c
index 26815cb..3aebab8 100644
--- a/src/gl-journal.c
+++ b/src/gl-journal.c
@@ -342,6 +342,8 @@ gl_journal_finalize (GObject *object)
         g_free (boot_id->boot_match);
     }
     g_array_free (priv->boot_ids, TRUE);
+
+    G_OBJECT_CLASS (gl_journal_parent_class)->finalize (object);
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]