[gnome-sudoku] Check visibility of earmark picker properly
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-sudoku] Check visibility of earmark picker properly
- Date: Mon, 14 Oct 2019 13:16:49 +0000 (UTC)
commit 2f3fb414d462f37dc629e34fd5984e9c0cd62211
Author: shak-mar <shakmar openmailbox org>
Date: Mon Oct 14 14:50:59 2019 +0200
Check visibility of earmark picker properly
See show_earmark_picker() in the same source file. The earmark picker
is actually shown inside the earmark_popover. Only the earmark_popover
is hidden when it loses focus, while the earmark picker always has
visibility true, which makes the check useless.
This fixes #33, which was caused by
1e8ebc849807df0e227c7a8f90f69b17c93e0d40.
src/sudoku-view.vala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/sudoku-view.vala b/src/sudoku-view.vala
index 93c6cbc..33be96c 100644
--- a/src/sudoku-view.vala
+++ b/src/sudoku-view.vala
@@ -284,7 +284,7 @@ private class SudokuCellView : Gtk.DrawingArea
k_no = key_map_keypad (k_name);
if (k_no >= 1 && k_no <= 9)
{
- bool want_earmark = (earmark_picker != null && earmark_picker.is_visible ())
+ bool want_earmark = (earmark_popover != null && earmark_popover.is_visible ())
|| (event.state & ModifierType.CONTROL_MASK) > 0;
if (want_earmark && game.mode == GameMode.PLAY)
{
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]