[eog: 2/3] Use plain gdk_pixbuf_loader_new(), not new_with_mime_type()



commit 31d5eded183dd33bec9ac52c47a6f4a97c4eea33
Author: Federico Mena Quintero <federico gnome org>
Date:   Fri Sep 6 15:27:26 2019 -0500

    Use plain gdk_pixbuf_loader_new(), not new_with_mime_type()
    
    The code to use new_with_mime_type() appeared in commit
    a3605db439ec78311fd6a5d6469a18a0f17cc1ba, with this comment:
    
            * src/eog-image.c (+eog_image_get_file_info,
            eog_image_real_load): force mime type on pixbuf loader in order to
            to recognize less usual image format like compressed SVG images.
            Fixes bug #394803 (Matthias Clasen, Felix Riemann).
    
    However, that version didn't have direct calls to librsvg yet, and it
    did not check the MIME type by hand to decide whether to call
    librsvg.  Now that that code is in place, we can let it do its job and
    just let gdk-pixbuf use its own format detection for GdkPixbufLoader.

 src/eog-image.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
---
diff --git a/src/eog-image.c b/src/eog-image.c
index 55cb1916..5c627c8e 100644
--- a/src/eog-image.c
+++ b/src/eog-image.c
@@ -990,14 +990,7 @@ eog_image_real_load (EogImage     *img,
 #endif
 
                if (!use_rsvg) {
-                       loader = gdk_pixbuf_loader_new_with_mime_type (mime_type, error);
-
-                       if (error && *error) {
-                               g_error_free (*error);
-                               *error = NULL;
-
-                               loader = gdk_pixbuf_loader_new ();
-                       }
+                       loader = gdk_pixbuf_loader_new ();
 
                        g_signal_connect_object (G_OBJECT (loader),
                                         "size-prepared",


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]