[libsoup/ntlm-v2-heap-buffer-overflow] Apply suggestion to libsoup/soup-auth-ntlm.c



commit c709ad398675792a6e1615a6bd55e44a1fbf9016
Author: Claudio Saavedra <csaavedra igalia com>
Date:   Wed Oct 9 09:09:56 2019 +0000

    Apply suggestion to libsoup/soup-auth-ntlm.c

 libsoup/soup-auth-ntlm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/libsoup/soup-auth-ntlm.c b/libsoup/soup-auth-ntlm.c
index 2985e740..2d078461 100644
--- a/libsoup/soup-auth-ntlm.c
+++ b/libsoup/soup-auth-ntlm.c
@@ -731,7 +731,7 @@ soup_ntlm_parse_challenge (const char *challenge,
        *ntlmv2_session = (flags & NTLM_FLAGS_NEGOTIATE_NTLMV2) ? TRUE : FALSE;
        /* To know if NTLMv2 responses should be calculated */
        *negotiate_target = (flags & NTLM_FLAGS_NEGOTIATE_TARGET_INFORMATION ) ? TRUE : FALSE;
-        if (*negotiate_target && target_info) {
+        if (*negotiate_target) {
             if (clen < NTLM_CHALLENGE_TARGET_INFORMATION_OFFSET + sizeof (target)) {
                 g_free (chall);
                 return FALSE;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]