[gnome-builder/1050-podman-absolute-workdir] podman: Canonicalize --workdir path



commit 7e3e5653df066e7a36bf279d330d7a7029afed7c
Author: Will Thompson <will willthompson co uk>
Date:   Wed Oct 2 12:10:08 2019 +0100

    podman: Canonicalize --workdir path
    
    ide_subprocess_launcher_get_cwd() may return "." or other relative
    paths, but podman's "--workdir" argument must be absolute.
    
    Fixes #1050.

 src/plugins/podman/gbp-podman-subprocess-launcher.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/src/plugins/podman/gbp-podman-subprocess-launcher.c 
b/src/plugins/podman/gbp-podman-subprocess-launcher.c
index 88ba6b785..f8b5ffe05 100644
--- a/src/plugins/podman/gbp-podman-subprocess-launcher.c
+++ b/src/plugins/podman/gbp-podman-subprocess-launcher.c
@@ -87,8 +87,10 @@ gbp_podman_subprocess_launcher_spawn (IdeSubprocessLauncher  *launcher,
 
       if ((cwd = ide_subprocess_launcher_get_cwd (launcher)))
         {
+          g_autofree gchar *cwd_absolute = g_canonicalize_filename (cwd, NULL);
+
           ide_subprocess_launcher_insert_argv (launcher, i++, "--workdir");
-          ide_subprocess_launcher_insert_argv (launcher, i++, cwd);
+          ide_subprocess_launcher_insert_argv (launcher, i++, cwd_absolute);
         }
 
       /* Determine how many FDs we need to preserve.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]