[balsa] build: make -Wformat-security effective



commit 0f4b8d874e456ab3a526a4dc0b7dac3546c63265
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date:   Tue Oct 1 20:41:23 2019 -0400

    build: make -Wformat-security effective
    
    We need -Wformat for -Wformat-security to be effective.
    
            * configure.ac:
            * meson.build:

 ChangeLog    | 7 +++++++
 configure.ac | 2 +-
 meson.build  | 1 +
 3 files changed, 9 insertions(+), 1 deletion(-)
---
diff --git a/ChangeLog b/ChangeLog
index 04a04d936..af33463d3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2019-10-01  Peter Bloomfield  <pbloomfield bellsouth net>
+
+       Build: we need -Wformat for -Wformat-security to be effective
+
+       * configure.ac:
+       * meson.build:
+
 2019-10-01  Peter Bloomfield  <pbloomfield bellsouth net>
 
        Build: GTimeVal, used in GtkSourceView-3, is deprecated in glib
diff --git a/configure.ac b/configure.ac
index 19ca20502..ec8393344 100644
--- a/configure.ac
+++ b/configure.ac
@@ -585,7 +585,7 @@ if test "$GCC" = "yes" -a "$set_more_warnings" != "no"; then
        for option in -Wsign-compare -Wpointer-arith -Wnested-externs \
             -Wchar-subscripts -Wuninitialized -Wmissing-prototypes    \
             -Wreturn-type -Wdeclaration-after-statement \
-            -Wredundant-decls -Wshadow -Wformat-security ; do
+            -Wredundant-decls -Wshadow -Wformat -Wformat-security ; do
                 SAVE_CFLAGS="$CFLAGS"
                 CFLAGS="$CFLAGS $option"
                 AC_MSG_CHECKING([whether gcc understands $option])
diff --git a/meson.build b/meson.build
index 54278c17f..89c9cb306 100644
--- a/meson.build
+++ b/meson.build
@@ -505,6 +505,7 @@ if balsa_from_git
     '-Wdeprecated-declarations',
     '-Wredundant-decls',
     '-Wshadow',
+    '-Wformat',
     '-Wformat-security',
     '-Wignored-qualifiers',
     '-DGMIME_DISABLE_DEPRECATED',


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]