[gnome-shell/T27795: 131/138] folderIcon: Stop notifying about name changes



commit 510b988e4aa78931ec573794b62b70cf38e38ab2
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Thu Sep 26 00:39:45 2019 -0300

    folderIcon: Stop notifying about name changes
    
    We don't really need to resort the icons, given that
    our app icon grid supports custom positions.

 js/ui/appDisplay.js | 14 --------------
 1 file changed, 14 deletions(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index d5bc27de1d..a9a7a193e7 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -448,17 +448,6 @@ var AllView = class AllView extends BaseAppView {
         this._nEventBlockerInhibits = 0;
     }
 
-    _itemNameChanged(item) {
-        // If an item's name changed, we can pluck it out of where it's
-        // supposed to be and reinsert it where it's sorted.
-        let oldIdx = this._allItems.indexOf(item);
-        this._allItems.splice(oldIdx, 1);
-        let newIdx = Util.insertSorted(this._allItems, item, this._compareItems);
-
-        this._grid.removeItem(item);
-        this._grid.addItem(item, newIdx);
-    }
-
     getAppInfos() {
         return this._appInfoList;
     }
@@ -494,7 +483,6 @@ var AllView = class AllView extends BaseAppView {
                 if (!icon) {
                     let item = Shell.DesktopDirInfo.new(itemId);
                     icon = new FolderIcon(item, this);
-                    icon.connect('name-changed', this._itemNameChanged.bind(this));
                 } else {
                     icon.update();
                 }
@@ -1386,7 +1374,6 @@ class ViewIcon extends GObject.Object {
 var FolderIcon = GObject.registerClass({
     Signals: {
         'apps-changed': {},
-        'name-changed': {},
      },
 }, class FolderIcon extends ViewIcon {
     _init(dirInfo, parentView) {
@@ -1537,7 +1524,6 @@ var FolderIcon = GObject.registerClass({
 
         this._name = name;
         this.icon.label.text = this._name;
-        this.emit('name-changed');
     }
 
     _redisplay() {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]