[gnome-shell] switcherPopup: Fix scrollable check



commit 867cffaf2093dbf3cad178356ea4716f02334073
Author: Florian Müllner <fmuellner gnome org>
Date:   Fri Nov 29 01:11:16 2019 +0100

    switcherPopup: Fix scrollable check
    
    When commit c6cea277e replaced Shell.GenericContainer, the check
    whether the required width exceeds the avilable width was changed
    from using the minimum widths of items to the natural width of the
    scroll view.
    
    That doesn't work correctly, as the *natural* width may well exceed
    the actually used width: SwitcherList bases its width request on
    children's minimum sizes to force labels to ellipsize.
    
    Fix this by using the minimum width of the scroll view's child instead.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/issues/1834

 js/ui/switcherPopup.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/switcherPopup.js b/js/ui/switcherPopup.js
index e5efcfaeca..48f44c90f7 100644
--- a/js/ui/switcherPopup.js
+++ b/js/ui/switcherPopup.js
@@ -575,10 +575,10 @@ var SwitcherList = GObject.registerClass({
         let leftPadding = this.get_theme_node().get_padding(St.Side.LEFT);
         let rightPadding = this.get_theme_node().get_padding(St.Side.RIGHT);
 
-        let [, natScrollViewWidth] = this._scrollView.get_preferred_width(height);
+        let [minListWidth] = this._list.get_preferred_width(height);
 
         let childBox = new Clutter.ActorBox();
-        let scrollable = natScrollViewWidth > width;
+        let scrollable = minListWidth > width;
 
         this._scrollView.allocate(contentBox, flags);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]