[glib-networking/mcatanzaro/allow-session-resumption] Allow session resumption when running tests again
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib-networking/mcatanzaro/allow-session-resumption] Allow session resumption when running tests again
- Date: Wed, 27 Nov 2019 22:55:05 +0000 (UTC)
commit 6a1a4874883b6026a45b8f090fc268db2e36ec09
Author: Michael Catanzaro <mcatanzaro gnome org>
Date: Wed Nov 27 16:53:50 2019 -0600
Allow session resumption when running tests again
Test!
tls/gnutls/gtlsclientconnection-gnutls.c | 14 --------------
1 file changed, 14 deletions(-)
---
diff --git a/tls/gnutls/gtlsclientconnection-gnutls.c b/tls/gnutls/gtlsclientconnection-gnutls.c
index 1d2ba78..e227896 100644
--- a/tls/gnutls/gtlsclientconnection-gnutls.c
+++ b/tls/gnutls/gtlsclientconnection-gnutls.c
@@ -128,20 +128,6 @@ g_tls_client_connection_gnutls_compute_session_id (GTlsClientConnectionGnutls *g
GInetAddress *iaddr;
guint port;
- /* The testsuite expects handshakes to actually happen. E.g. a test might
- * check to see that a handshake succeeds and then later check that a new
- * handshake fails. If we get really unlucky and the same port number is
- * reused for the server socket between connections, then we'll accidentally
- * resume the old session and skip certificate verification. Such failures
- * are difficult to debug because they require running the tests hundreds of
- * times simultaneously to reproduce (the port number does not get reused
- * quickly enough if the tests are run sequentially).
- *
- * So session resumption will just need to be tested manually.
- */
- if (g_test_initialized ())
- return;
-
/* Create a TLS "session ID." We base it on the IP address since
* different hosts serving the same hostname/service will probably
* not share the same session cache. We base it on the
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]