[glib/wip/oholy/gio-mount-uuid: 2/2] gio-tool-mount: Do not print anything if "gio mount -d" suceeded



commit dd49962eaf9c9296e9daaeb2cbff40fd674b2d8c
Author: Ondrej Holy <oholy redhat com>
Date:   Wed Nov 27 13:25:44 2019 +0100

    gio-tool-mount: Do not print anything if "gio mount -d" suceeded
    
    "gio mount" doesn't print anything in case of success, however "gio mount -d"
    prints "Mounted [id] at [mount_path]", which is inconsistent. It might probably
    make sense for fstab volumes, but "gio mount -d" now support UUIDs which are
    heavily used for daemon mounts and I think that it is not wise to print
    "/run/user/$UID/gvfs" mount paths. The mount path can be still found over
    "gio mount -l". Let's remove this message to make it more consistent.

 gio/gio-tool-mount.c | 16 ----------------
 1 file changed, 16 deletions(-)
---
diff --git a/gio/gio-tool-mount.c b/gio/gio-tool-mount.c
index 13ddad917..67278bb5c 100644
--- a/gio/gio-tool-mount.c
+++ b/gio/gio-tool-mount.c
@@ -962,22 +962,6 @@ mount_with_device_file_cb (GObject *object,
       g_error_free (error);
       success = FALSE;
     }
-  else
-    {
-      GMount *mount;
-      GFile *root;
-      char *mount_path;
-
-      mount = g_volume_get_mount (volume);
-      root = g_mount_get_root (mount);
-      mount_path = g_file_get_path (root);
-
-      g_print (_("Mounted %s at %s\n"), id, mount_path);
-
-      g_object_unref (mount);
-      g_object_unref (root);
-      g_free (mount_path);
-    }
 
   g_free (id);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]