[epiphany/mcatanzaro/#1012] lineup-parameters: fix python warning about suspicious comparison



commit 4b1a74eab2116b20cad1df53365862ca449e0c97
Author: Michael Catanzaro <mcatanzaro gnome org>
Date:   Tue Nov 26 19:09:37 2019 -0600

    lineup-parameters: fix python warning about suspicious comparison
    
    This needs to use == because the is operator checks whether the two
    variables are the same instance, not whether they have the same value.
    
    Fixes #1012

 data/lineup-parameters | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/data/lineup-parameters b/data/lineup-parameters
index 4bfc39194..aae22de0e 100755
--- a/data/lineup-parameters
+++ b/data/lineup-parameters
@@ -99,7 +99,7 @@ def matchParameter(line):
     stars = match.group('stars')
     numStars = len(stars) if stars is not None else 0
     end = match.group('end')
-    isLastParameter = True if end is not None and end is ')' else False
+    isLastParameter = True if end is not None and end == ')' else False
     return ParameterInfo(paramType, name, numStars, isLastParameter)
 
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]