[gnome-settings-daemon] media-keys: Skip volume-change feedback while playing



commit 7d74327dc2bfc9dcfd1fb56f6d6206db32d63894
Author: Florian Müllner <fmuellner gnome org>
Date:   Sat Nov 23 03:14:23 2019 +0100

    media-keys: Skip volume-change feedback while playing
    
    The audio feedback for volume changes is useful when nothing is outputting
    sound, but only then. Skip the sound notification in that case.

 plugins/media-keys/gsd-media-keys-manager.c | 5 ++++-
 subprojects/gvc                             | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/plugins/media-keys/gsd-media-keys-manager.c b/plugins/media-keys/gsd-media-keys-manager.c
index 4e167c86..a7155d2f 100644
--- a/plugins/media-keys/gsd-media-keys-manager.c
+++ b/plugins/media-keys/gsd-media-keys-manager.c
@@ -1359,6 +1359,7 @@ update_dialog (GsdMediaKeysManager *manager,
         GvcMixerUIDevice *device;
         const GvcMixerStreamPort *port;
         const char *icon;
+        gboolean playing;
         double new_vol;
         double max_volume;
 
@@ -1383,7 +1384,9 @@ update_dialog (GsdMediaKeysManager *manager,
                 show_osd_with_max_level (manager, icon, NULL, new_vol, max_volume, NULL);
         }
 
-        if (quiet == FALSE && sound_changed != FALSE && muted == FALSE) {
+        playing = gvc_mixer_stream_get_state (stream) == GVC_STREAM_STATE_RUNNING;
+
+        if (quiet == FALSE && sound_changed != FALSE && muted == FALSE && playing == FALSE) {
                 ensure_canberra (manager);
                 ca_context_change_device (priv->ca,
                                           gvc_mixer_stream_get_name (stream));
diff --git a/subprojects/gvc b/subprojects/gvc
index 6a0ac9ba..ec5cf3e0 160000
--- a/subprojects/gvc
+++ b/subprojects/gvc
@@ -1 +1 @@
-Subproject commit 6a0ac9ba69f84d763f286c5741b57ff8d87c1f45
+Subproject commit ec5cf3e0de6715803e64b65abb059e2155b3d6de


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]