[gnome-shell/wip/fmuellner/volume-change-feedback: 17/17] volume: Skip volume-change feedback while playing



commit e0c5b6ccb578028e7ece7a1db4b0ba0a6ab78fbd
Author: Florian Müllner <fmuellner gnome org>
Date:   Fri Nov 22 18:37:25 2019 +0100

    volume: Skip volume-change feedback while playing
    
    The audio feedback for volume changes is useful when nothing is outputting
    sound, but only then. Skip the sound notification in that case.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/issues/53

 js/ui/status/volume.js | 3 +++
 subprojects/gvc        | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
---
diff --git a/js/ui/status/volume.js b/js/ui/status/volume.js
index 6be1b2f6a7..e1dd8f7c4c 100644
--- a/js/ui/status/volume.js
+++ b/js/ui/status/volume.js
@@ -136,6 +136,9 @@ var StreamSlider = class {
     }
 
     _notifyVolumeChange() {
+        if (this._stream.state === Gvc.MixerStreamState.RUNNING)
+            return; // feedback not necessary while playing
+
         if (this._volumeCancellable)
             this._volumeCancellable.cancel();
 
diff --git a/subprojects/gvc b/subprojects/gvc
index 0e1b4bdafc..ec5cf3e0de 160000
--- a/subprojects/gvc
+++ b/subprojects/gvc
@@ -1 +1 @@
-Subproject commit 0e1b4bdafc364d5b62ffd14847e9e6ecfefbf2c9
+Subproject commit ec5cf3e0de6715803e64b65abb059e2155b3d6de


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]