[gnome-shell/gnome-3-34] switcherPopup: Improve modifier-less keybinding navigation

[Florian Müllner <fmuellner src gnome org>]

commit c752682ab976c71ea8c886075b97cdd2df7bbc9c
Author: Florian Müllner <fmuellner gnome org>
Date:   Mon Nov 11 22:00:01 2019 +0100

    switcherPopup: Improve modifier-less keybinding navigation
    
    Commit c899453800f11 lifted the requirement of switcher keybindings
    to contain a modifier, however it is currently only possible to
    finish it by letting it time out.
    
    Improve that by also accepting space/enter key presses to confirm the
    selection immediately.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/issues/1883

 js/ui/switcherPopup.js | 8 ++++++++
 1 file changed, 8 insertions(+)
---
diff --git a/js/ui/switcherPopup.js b/js/ui/switcherPopup.js
index c956eea435..30b380f648 100644
--- a/js/ui/switcherPopup.js
+++ b/js/ui/switcherPopup.js
@@ -180,6 +180,14 @@ var SwitcherPopup = GObject.registerClass({
         if (keysym == Clutter.Escape || keysym == Clutter.Tab)
             this.fadeAndDestroy();
 
+        // Allow to explicitly select the current item; this is particularly
+        // useful for no-modifier popups
+        if (keysym === Clutter.KEY_space ||
+            keysym === Clutter.KEY_Return ||
+            keysym === Clutter.KEY_KP_Enter ||
+            keysym === Clutter.KEY_ISO_Enter)
+            this._finish(keyEvent.time);
+
         return Clutter.EVENT_STOP;
     }