[gnome-shell/wip/fmuellner/volume-change-feedback: 1660/1660] volume: Skip volume-change feedback while playing
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/fmuellner/volume-change-feedback: 1660/1660] volume: Skip volume-change feedback while playing
- Date: Fri, 22 Nov 2019 19:23:15 +0000 (UTC)
commit 5d38756e232b7d003596c354cc71c252e95ecc15
Author: Florian Müllner <fmuellner gnome org>
Date: Fri Nov 22 18:37:25 2019 +0100
volume: Skip volume-change feedback while playing
The audio feedback for volume changes is useful when nothing is outputting
sound, but only then. Skip the sound notification in that case.
https://gitlab.gnome.org/GNOME/gnome-shell/issues/53
js/ui/status/volume.js | 3 +++
1 file changed, 3 insertions(+)
---
diff --git a/js/ui/status/volume.js b/js/ui/status/volume.js
index 6be1b2f6a7..e1dd8f7c4c 100644
--- a/js/ui/status/volume.js
+++ b/js/ui/status/volume.js
@@ -136,6 +136,9 @@ var StreamSlider = class {
}
_notifyVolumeChange() {
+ if (this._stream.state === Gvc.MixerStreamState.RUNNING)
+ return; // feedback not necessary while playing
+
if (this._volumeCancellable)
this._volumeCancellable.cancel();
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]