[libgda: 1/3] meson: libgda library will be compiled with -Werror



commit 73c4f71619d96c4450a0900721eddb7af8ce9329
Author: Pavlo Solntsev <p sun fun gmail com>
Date:   Fri Nov 1 00:07:57 2019 -0500

    meson: libgda library will be compiled with -Werror
    
    -Werror parameter will be passed in CI config file
    where experimental features are disable.

 .gitlab-ci.yml            |  2 +-
 libgda/gda-data-handler.c |  2 +-
 libgda/gda-data-pivot.c   |  3 ---
 libgda/meson.build        | 40 ++++++++++++++++++++--------------------
 4 files changed, 22 insertions(+), 25 deletions(-)
---
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index c07c0b2b5..849102e98 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -68,7 +68,7 @@ library_build:
   script:
   - export PGPASSWORD=$POSTGRES_PASSWORD
   - psql -h "postgres" -U "$POSTGRES_USER" -d "$POSTGRES_DB" -c "SELECT 'OK' AS status;"
-  - meson _build --prefix=/usr -Denable-debug=true -Dgtk_doc=true
+  - meson _build --prefix=/usr -Denable-debug=true -Dgtk_doc=true -Dc_args="-Werror"
   - cd _build
   - ninja
   - broadwayd &
diff --git a/libgda/gda-data-handler.c b/libgda/gda-data-handler.c
index 8c1930267..76b6e6b84 100644
--- a/libgda/gda-data-handler.c
+++ b/libgda/gda-data-handler.c
@@ -259,7 +259,7 @@ gda_data_handler_get_descr (GdaDataHandler *dh)
 GdaDataHandler *
 gda_data_handler_get_default (GType for_type)
 {
-       GdaDataHandler *dh;
+       GdaDataHandler *dh = NULL;
 
   if (for_type == G_TYPE_INT64) {
     dh = gda_handler_numerical_new ();
diff --git a/libgda/gda-data-pivot.c b/libgda/gda-data-pivot.c
index 1df9b74fe..b5dfb4e37 100644
--- a/libgda/gda-data-pivot.c
+++ b/libgda/gda-data-pivot.c
@@ -140,8 +140,6 @@ gda_data_pivot_class_init (GdaDataPivotClass *klass)
        object_class->dispose = gda_data_pivot_dispose;
 }
 
-#define gda_data_pivot_get_instance_private(obj) G_TYPE_INSTANCE_GET_PRIVATE(obj, GDA_TYPE_DATA_PIVOT, 
GdaDataPivotPrivate)
-
 static void
 gda_data_pivot_data_model_init (GdaDataModelInterface *iface)
 {
@@ -170,7 +168,6 @@ gda_data_pivot_data_model_init (GdaDataModelInterface *iface)
 static void
 gda_data_pivot_init (GdaDataPivot *model)
 {
-       g_return_if_fail (GDA_IS_DATA_PIVOT (model));
        GdaDataPivotPrivate *priv = gda_data_pivot_get_instance_private (model);
        priv->model = NULL;
 }
diff --git a/libgda/meson.build b/libgda/meson.build
index 7beb6ab48..899688f58 100644
--- a/libgda/meson.build
+++ b/libgda/meson.build
@@ -78,16 +78,16 @@ libgda_headers = files([
        'gda-data-proxy.h',
        'gda-data-select.h',
        'gda-data-select-private.h',
-        'gda-db-catalog.h',
-        'gda-db-table.h',
-        'gda-db-view.h',
-        'gda-db-column.h',
-        'gda-db-fkey.h',
-        'gda-db-base.h',
-        'gda-db-buildable.h',
-       'gda-decl.h',
-       'gda-holder.h',
-       'gda-lockable.h',
+  'gda-db-catalog.h',
+  'gda-db-table.h',
+  'gda-db-view.h',
+  'gda-db-column.h',
+  'gda-db-fkey.h',
+  'gda-db-base.h',
+  'gda-db-buildable.h',
+  'gda-decl.h',
+  'gda-holder.h',
+  'gda-lockable.h',
        'gda-log.h',
        'gda-meta-store.h',
        'gda-meta-struct.h',
@@ -149,16 +149,16 @@ libgda_sources= files([
        'gda-data-access-wrapper.c',
        'gda-data-proxy.c',
        'gda-data-select.c',
-        'gda-db-catalog.c',
-        'gda-db-table.c',
-        'gda-db-view.c',
-        'gda-db-column.c',
-        'gda-db-fkey.c',
-        'gda-db-base.c',
-        'gda-db-buildable.c',
-       'gda-holder.c',
-       'gda-init.c',
-       'gda-lockable.c',
+  'gda-db-catalog.c',
+  'gda-db-table.c',
+  'gda-db-view.c',
+  'gda-db-column.c',
+  'gda-db-fkey.c',
+  'gda-db-base.c',
+  'gda-db-buildable.c',
+  'gda-holder.c',
+  'gda-init.c',
+  'gda-lockable.c',
        'gda-log.c',
        'gda-meta-store.c',
        'gda-meta-struct.c',


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]