[gnome-shell/gbsneto/dont-create-so-many-icons-pretty-please: 3/3] appIcon: Remove drag monitor on destroy

[Georges Basile Stavracas Neto <gbsneto src gnome org>]

commit 0e21b4e6b54bf1e05e1a719ed72d47993e296aeb
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Thu Nov 21 18:50:11 2019 -0300

    appIcon: Remove drag monitor on destroy
    
    It may happen that the app icon is destroyed with a drag
    monitor still around, in which case, a load of warnings
    will be shown.
    
    Make sure to remove any pending drag monitor on destroy.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/841

 js/ui/appDisplay.js | 7 +++++++
 1 file changed, 7 insertions(+)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 0180fb28fc..c8cab6f357 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -2132,6 +2132,7 @@ var AppIcon = GObject.registerClass({
             });
         }
 
+        this._dragMonitor = null;
         this._itemDragBeginId = Main.overview.connect(
             'item-drag-begin', this._onDragBegin.bind(this));
         this._itemDragEndId = Main.overview.connect(
@@ -2156,6 +2157,12 @@ var AppIcon = GObject.registerClass({
         }
         if (this._stateChangedId > 0)
             this.app.disconnect(this._stateChangedId);
+
+        if (this._dragMonitor) {
+            DND.removeDragMonitor(this._dragMonitor);
+            this._dragMonitor = null;
+        }
+
         if (this._draggable) {
             if (this._dragging)
                 Main.overview.endItemDrag(this);