[gnome-shell/gbsneto/dont-create-so-many-icons-pretty-please: 1/3] baseAppView: Destroy icon when removing



commit 8bf3c3e1d89264b0d1dd6ca936f04f23aeb75ab5
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Thu Nov 21 18:21:44 2019 -0300

    baseAppView: Destroy icon when removing
    
    We cannot rely on the garbage collector to do that in a timely
    manner, so destroy it explicitly.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/841

 js/ui/appDisplay.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index a49ebe09a8..0634962b3f 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -188,7 +188,7 @@ var BaseAppView = GObject.registerClass({
             let iconIndex = this._allItems.indexOf(icon);
 
             this._allItems.splice(iconIndex, 1);
-            this._grid.removeItem(icon);
+            icon.destroy();
             delete this._items[icon.id];
         });
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]