[vte] terminal: Remove redundant function



commit 4af0f18d5fb35a15c5b7003ccd4b2fcc7a98af53
Author: Christian Persch <chpe src gnome org>
Date:   Thu Nov 21 20:01:30 2019 +0100

    terminal: Remove redundant function
    
    feed_child_using_modes was redundant with send_child since the
    removal of SRM mode.

 src/vte.cc         | 17 +++--------------
 src/vteinternal.hh |  2 --
 2 files changed, 3 insertions(+), 16 deletions(-)
---
diff --git a/src/vte.cc b/src/vte.cc
index 99be7950..ee60dfd1 100644
--- a/src/vte.cc
+++ b/src/vte.cc
@@ -4255,17 +4255,6 @@ Terminal::feed_child_binary(guint8 const* data,
        }
 }
 
-void
-Terminal::feed_child_using_modes(char const* data,
-                                           gssize length)
-{
-       if (length == -1)
-               length = strlen(data);
-
-       if (length > 0)
-                send_child(data, length);
-}
-
 void
 Terminal::send(vte::parser::u8SequenceBuilder const& builder,
                          bool c1,
@@ -4367,7 +4356,7 @@ Terminal::im_commit(char const* text)
 {
        _vte_debug_print(VTE_DEBUG_EVENTS,
                        "Input method committed `%s'.\n", text);
-       feed_child_using_modes(text, -1);
+       send_child(text, strlen(text));
        /* Committed text was committed because the user pressed a key, so
         * we need to obey the scroll-on-keystroke setting. */
         if (m_scroll_on_keystroke && m_input_enabled) {
@@ -5042,7 +5031,7 @@ Terminal::widget_key_press(GdkEventKey *event)
                                feed_child(_VTE_CAP_ESC, 1);
                        }
                        if (normal_length > 0) {
-                               feed_child_using_modes(normal, normal_length);
+                               send_child(normal, normal_length);
                        }
                        g_free(normal);
                }
@@ -9612,7 +9601,7 @@ Terminal::widget_scroll(GdkEventScroll *event)
                if (cnt < 0)
                        cnt = -cnt;
                for (i = 0; i < cnt; i++) {
-                       feed_child_using_modes(normal, normal_length);
+                       send_child(normal, normal_length);
                }
                g_free (normal);
        } else {
diff --git a/src/vteinternal.hh b/src/vteinternal.hh
index 5484bceb..823e7f0e 100644
--- a/src/vteinternal.hh
+++ b/src/vteinternal.hh
@@ -974,8 +974,6 @@ public:
 
         void send_child(char const* data,
                         gssize length) noexcept;
-        void feed_child_using_modes(char const* data,
-                                    gssize length);
 
         void watch_child (pid_t child_pid);
         bool terminate_child () noexcept;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]