[gnome-shell] dateMenu: Skip weather forecast if not valid



commit b779f6f72810ec06c4ddebf37680a6f254b61921
Author: Philip Chimento <philip endlessm com>
Date:   Tue Nov 19 13:31:57 2019 -0800

    dateMenu: Skip weather forecast if not valid
    
    GWeather.Info.get_value_update() may indicate that the forecast is not
    valid, or it may return a timestamp of 0 to indicate the information has
    never been updated. In both of these cases, skip creating a widget for
    it, as the information will not be accurate.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/835

 js/ui/dateMenu.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/js/ui/dateMenu.js b/js/ui/dateMenu.js
index 51413c5660..17e6d1723e 100644
--- a/js/ui/dateMenu.js
+++ b/js/ui/dateMenu.js
@@ -333,7 +333,9 @@ class WeatherSection extends St.Button {
 
         let col = 0;
         infos.forEach(fc => {
-            let [ok_, timestamp] = fc.get_value_update();
+            const [valid, timestamp] = fc.get_value_update();
+            if (!valid || timestamp === 0)
+                return;  // 0 means 'never updated'
             let timeStr = Util.formatTime(new Date(timestamp * 1000), {
                 timeOnly: true,
                 ampm: false,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]