[mutter/wip/carlosg/fix-dnd-crash: 16/18] wayland: Avoid redundant cancel() call



commit e7b2f9603e90d87092c9e755c176f1244a8b3e36
Author: Carlos Garnacho <carlosg gnome org>
Date:   Wed Nov 20 00:29:01 2019 +0100

    wayland: Avoid redundant cancel() call
    
    This is unnecessary as we are unsetting the DnD selection owner,
    and will result in the related data source being cancelled already.
    
    https://gitlab.gnome.org/GNOME/mutter/issues/591

 src/wayland/meta-wayland-data-device.c | 1 -
 1 file changed, 1 deletion(-)
---
diff --git a/src/wayland/meta-wayland-data-device.c b/src/wayland/meta-wayland-data-device.c
index 3a9f276aa..5a669b5f5 100644
--- a/src/wayland/meta-wayland-data-device.c
+++ b/src/wayland/meta-wayland-data-device.c
@@ -1068,7 +1068,6 @@ drag_grab_button (MetaWaylandPointerGrab *grab,
         }
       else
         {
-          meta_wayland_data_source_cancel (source);
           meta_wayland_data_source_set_current_offer (source, NULL);
           meta_wayland_data_device_set_dnd_source (&seat->data_device, NULL);
           unset_selection_source (&seat->data_device, META_SELECTION_DND);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]