[gnome-music/wip/jfelder/3-34-window-overlay-children] window: Fix overlay children



commit f7c0982d239c82504056c7bf7fab6b37c269cc45
Author: Jean Felder <jfelder src gnome org>
Date:   Mon Nov 18 18:05:18 2019 +0100

    window: Fix overlay children
    
    The main window contains an overlay widget. It allows to display
    notifications on top of the current view (the main stack). However,
    during the initial port of Window to a template (commit
    a2e9d1933d1b48dad06b8fb26d67e12dfad9926c), both children (the main
    stack and the notification widget) have become "overlay" widgets
    instead of the notification widget only.
    
    This change can result in some strange issues such as #337.
    
    Fix the issue by removing the overlay type of the main stack: the main
    stack is the only child of the overlay. The notification widget is an
    "overlay" child.
    
    Closes: #337
    (cherry picked from commit 8d22d4b24ceddcbe492cf36a57933498cf946339)

 data/ui/Window.ui | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/data/ui/Window.ui b/data/ui/Window.ui
index 558960a5..161b3059 100644
--- a/data/ui/Window.ui
+++ b/data/ui/Window.ui
@@ -11,7 +11,7 @@
           <object class="GtkOverlay" id="_overlay">
             <property name="vexpand">True</property>
             <property name="visible">True</property>
-            <child type="overlay">
+            <child>
               <object class="GtkStack" id="_stack">
                 <property name="can-focus">False</property>
                 <property name="homogeneous">False</property>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]