[epiphany/mcatanzaro/cppcheck: 1/11] Adjust cppcheck output
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/mcatanzaro/cppcheck: 1/11] Adjust cppcheck output
- Date: Sun, 17 Nov 2019 17:45:07 +0000 (UTC)
commit a8705be6bbc99f4670388f612f8cbbdbd3258f86
Author: Michael Catanzaro <mcatanzaro gnome org>
Date: Sun Nov 17 09:37:16 2019 -0600
Adjust cppcheck output
Using --template=gcc allows us to see error IDs so that we can suppress
false positives.
Also, add a bunch of suppressions for warnings that cppcheck is bad at
handling. Sadly, the most important warnings, like null pointer
dereference, are prone to many false positives, making them impractical
for us to use.
We also suppress warnings about non-casted NULL pointers at the end of a
variadic argument list. This is undefined behavior -- to avoid UB, we
should use (char *)NULL instead -- but glib depends on it and nothing
will work if this isn't allowed, so we had better ignore.
.gitlab-ci.yml | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
---
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 476b592b4..03f255d27 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -19,8 +19,23 @@ cppcheck:
allow_failure: true
before_script:
- apk update && apk add cppcheck
- script:
- - cppcheck --enable=all --suppress=variableScope --suppress=unusedFunction --force -q .
--error-exitcode=1 --library=gtk
+ script: >-
+ cppcheck .
+ --enable=all
+ --error-exitcode=1
+ --library=gtk
+ --quiet
+ --suppress=ctunullpointer
+ --suppress=leakNoVarFunctionCall
+ --suppress=literalWithCharPtrCompare
+ --suppress=memleak
+ --suppress=missingInclude
+ --suppress=redundantAssignment
+ --suppress=variableScope
+ --suppress=unusedFunction
+ --suppress=varFuncNullUB
+ --suppress=*:lib/contrib/gvdb/*
+ --template=gcc
variables:
BUNDLE: 'epiphany-git.flatpak'
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]