[epiphany/mcatanzaro/cppcheck: 4/12] embed-shell: placate cppcheck



commit 4825d5b799366b3b779cc4e77b41519b68f1516e
Author: Michael Catanzaro <mcatanzaro gnome org>
Date:   Sun Nov 17 09:20:22 2019 -0600

    embed-shell: placate cppcheck
    
    It doesn't like us shadowing the global embed_shell here.

 embed/ephy-embed-shell.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/embed/ephy-embed-shell.c b/embed/ephy-embed-shell.c
index ce374f95a..22e20a38b 100644
--- a/embed/ephy-embed-shell.c
+++ b/embed/ephy-embed-shell.c
@@ -147,7 +147,6 @@ ephy_embed_shell_get_extension_proxy_for_page_id (EphyEmbedShell *self,
 static GList *
 tabs_catalog_get_tabs_info (EphyTabsCatalog *catalog)
 {
-  EphyEmbedShell *embed_shell = EPHY_EMBED_SHELL (catalog);
   WebKitFaviconDatabase *database;
   GList *windows;
   g_autoptr (GList) tabs = NULL;
@@ -156,6 +155,8 @@ tabs_catalog_get_tabs_info (EphyTabsCatalog *catalog)
   const char *url;
   g_autofree char *favicon = NULL;
 
+  g_assert ((gpointer)catalog == (gpointer)embed_shell);
+
   windows = gtk_application_get_windows (GTK_APPLICATION (embed_shell));
   database = webkit_web_context_get_favicon_database (ephy_embed_shell_get_web_context (embed_shell));
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]